Call mMediaCache->ReleaseStream() in MediaCacheStream::CloseInternal()

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

So we won't need to take the cache monitor on the main thread.
Assignee: nobody → jwwang
Blocks: 1369263
Priority: -- → P3
Attachment #8939448 - Flags: review?(bechen)
Comment on attachment 8939448 [details]
Bug 1427667 - move the call to mMediaCache->ReleaseStream() from the destructor to CloseInternal().

https://reviewboard.mozilla.org/r/209774/#review215314
Attachment #8939448 - Flags: review?(bechen) → review+
Attachment #8939448 - Flags: review?(gsquelart)
Comment on attachment 8939448 [details]
Bug 1427667 - move the call to mMediaCache->ReleaseStream() from the destructor to CloseInternal().

https://reviewboard.mozilla.org/r/209774/#review215316
Attachment #8939448 - Flags: review?(gsquelart) → review+
Thanks for the reviews!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a054313a69b7
move the call to mMediaCache->ReleaseStream() from the destructor to CloseInternal(). r=bechen,gerald
https://hg.mozilla.org/mozilla-central/rev/a054313a69b7
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Depends on: 1428184
You need to log in before you can comment on or make changes to this bug.