Closed Bug 1427667 Opened 3 years ago Closed 3 years ago

Call mMediaCache->ReleaseStream() in MediaCacheStream::CloseInternal()

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

So we won't need to take the cache monitor on the main thread.
Assignee: nobody → jwwang
Blocks: 1369263
Priority: -- → P3
Attachment #8939448 - Flags: review?(bechen)
Comment on attachment 8939448 [details]
Bug 1427667 - move the call to mMediaCache->ReleaseStream() from the destructor to CloseInternal().

https://reviewboard.mozilla.org/r/209774/#review215314
Attachment #8939448 - Flags: review?(bechen) → review+
Attachment #8939448 - Flags: review?(gsquelart)
Comment on attachment 8939448 [details]
Bug 1427667 - move the call to mMediaCache->ReleaseStream() from the destructor to CloseInternal().

https://reviewboard.mozilla.org/r/209774/#review215316
Attachment #8939448 - Flags: review?(gsquelart) → review+
Thanks for the reviews!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a054313a69b7
move the call to mMediaCache->ReleaseStream() from the destructor to CloseInternal(). r=bechen,gerald
https://hg.mozilla.org/mozilla-central/rev/a054313a69b7
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Depends on: 1428184
You need to log in before you can comment on or make changes to this bug.