NSIS newlines not escaped

RESOLVED FIXED in Firefox 59

Status

()

defect
RESOLVED FIXED
2 years ago
10 months ago

People

(Reporter: chagnon.joey, Assigned: chagnon.joey)

Tracking

Trunk
Firefox 59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180101100404

Steps to reproduce:

1. Create the directory %USERPROFILE%\Local\Mozilla Firefox
2. Deny yourself write access to the directory through some means.
3. Run the Firefox installer.



Actual results:

A MessageBox pops up with the following text:

You don't have access to write to the installation directory\n\n<dir>


Expected results:

A MessageBox should appear with the following text:

You don't have access to write to the installation directory

<dir>
Comment on attachment 8939471 [details]
Bug 1427670 - Escape warning message when the user can't write to their profile.

https://reviewboard.mozilla.org/r/209812/#review215520

Please request review from mhowell for this.
Attachment #8939471 - Flags: review?(robert.strong.bugs)
Comment on attachment 8939471 [details]
Bug 1427670 - Escape warning message when the user can't write to their profile.

https://reviewboard.mozilla.org/r/209812/#review215880

Looks good to me! Thanks for the patch.
Attachment #8939471 - Flags: review?(mhowell) → review+
Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e43ed104f056
Escape warning message when the user can't write to their profile. r=mhowell
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/29e0ea0b2470
Escape warning message when the user can't write to their profile. r=mhowell
https://hg.mozilla.org/mozilla-central/rev/29e0ea0b2470
Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Assignee: nobody → chagnon.joey
You need to log in before you can comment on or make changes to this bug.