1427807 - WebDriver:GetCookies does not return cookies from frames

Status: NEW

(Remote Protocol :: Marionette, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Originally filed as https://github.com/mozilla/geckodriver/issues/1104

With bug 1371733 (fixed in Firefox 56) the cookies are collected via the parent process now. As such it seems that we have no longer access to cookies as defined in frames.

Here a simple Marionette test showing this problem (based on a reporter testcase):

    def test(self):
        self.marionette.navigate("https://x.zok.pw/geckodrivertest/outer.html")
        frame = self.marionette.find_element(By.ID, "subframe")
        self.marionette.switch_to_frame(frame)
        self.assertIsNotNone(self.marionette.get_cookie("inner"))

Andreas, could you please have a look?

Comment 1

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) [mostly away Dec 11th - Jan
3rd] from comment #0)

> With bug 1371733 (fixed in Firefox 56) the cookies are collected
> via the parent process now. As such it seems that we have no
> longer access to cookies as defined in frames.

We always got the cookies from chrome space, but I’d bet we need to
use the hostname of the current frame (fetched from listener.js)
instead of the browser’s current URL when enumerating them.

Comment 2

[Maxim Tsoy]

Hi, I am the original reporter of this issue.
Is there any workaround that I can use in selenium test with geckodriver?

Comment 3

[David Burns :automatedtester]

[Mass Change 2018-01-15] Moving bugs to backlog

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late to fix in 59, but we can still take a patch in Nightly.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Happy to take a patch in nightly; if it seems low risk enough please feel free to request uplift to 65 beta.

Comment 6

[meni.pablo]

Hi, is there any update on this ticket?

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry, but not as of this point. This broken behavior is not high on our priority list. But if someone has interest to work on it, I'm happy to mentor.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Meni.pablo as we spoke on Matrix I would be interested if you still want to help or if you wont have the time anymore. Thanks.

Comment 9

[meni.pablo]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #8)

Meni.pablo as we spoke on Matrix I would be interested if you still want to help or if you wont have the time anymore. Thanks.

Yes, I am still interested in this. I'll reach out to you on Matrix for the next steps