Closed Bug 1427809 Opened 2 years ago Closed 2 years ago

Enable Simplify Print Feature by default on Linux

Categories

(Toolkit :: Printing, enhancement)

Unspecified
Linux
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: mlongaray, Assigned: mlongaray)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

When Simplify Page was shipped to release population, Bug 1306295 and Bug 1306297 ended up disabling Simplify MVP for Linux - making it only available by default on Nightly channel.

I asked Bogdan Marris to verify if these issues were still reproducible and it was confirmed these issues are indeed _not_ reproducible anymore on latest Nightly. I’m assuming that’s because patches from Bug 1365601 landed.

If QA is comfortable with Simplify Page on Linux, this bug is about turning the feature on by default on Linux.
Hey Bogdan, please feel free to share any thoughts or recommendations you might have about this. Also, if there's anyone else you think we should add to this thread, please do so.
Flags: needinfo?(bogdan.maris)
PS: bug filed as per Mike's request.
Mike, please add anyone else from QA you think might important for evaluating this one.
Flags: needinfo?(mconley)
Let's see if Bogdan gets back to us once the post-holiday catch-up subsides - I suspect he can help us identify the right people to get involved here.
Flags: needinfo?(mconley)
Comment on attachment 8939604 [details]
Bug 1427809 - Enable Simplify Print Feature by default on Linux.

https://reviewboard.mozilla.org/r/209916/#review215550

Patch looks good to me - however, I'm reluctant to land this until we're certain that QA is happy with its behaviour. So I'll wait for their feedback before r+'ing.
Attachment #8939604 - Flags: review?(mconley)
Roger! Totally agree - submitted the patch right away only because I had the time for it :)
Hello!
Since we are going to release Fx58 in a few weeks, my suggestion would be to enable this feature starting with Fx60 (this would be the safest way since there could be interoperability issues with printing, reading list etc). 
We can do some exploratory testing in Nightly 60 (since we only verified those bugs from comment 0) then let it ride the trains and test it through each phase properly. Does this sound good to you guys?
Flags: needinfo?(mlongaray)
Flags: needinfo?(mconley)
Flags: needinfo?(bogdan.maris)
That sounds good to me, thanks!
Flags: needinfo?(mconley)
Do I need to fill out a PI request, or have we given you enough information to start the testing for Fx60?
Flags: needinfo?(bogdan.maris)
Flags: needinfo?(mlongaray)
(In reply to Mike Conley (:mconley) (:⚙️) - Backlogged on reviews and needinfos from comment #10)
> Do I need to fill out a PI request, or have we given you enough information
> to start the testing for Fx60?

Filling a PI request will be what we want since this is how we'll prioritize the features for Fx60.
Flags: needinfo?(bogdan.maris)
Okay, request sent. Thanks!
Hi Bogdan,

Thanks for all of your work testing the feature and filing the bugs blocking bug 1440631. None of those bugs seem to me like show-stoppers. Do you think we are at the point where I can land this pref flip?
Flags: needinfo?(bogdan.maris)
(In reply to Mike Conley (:mconley) (:⚙️) (Totally backlogged on reviews and needinfos) from comment #13)
> Hi Bogdan,
> 
> Thanks for all of your work testing the feature and filing the bugs blocking
> bug 1440631. None of those bugs seem to me like show-stoppers. Do you think
> we are at the point where I can land this pref flip?

Hello Mike! Thanks for taking the time to go through the bugs from bug 1440631. After your feedback (Gijs and Matheus as well) we can conclude that this feature will receive a green status for the upcoming pre-Beta sign-off (scheduled for this Friday) so yes, I and Anca think that we can go ahead and land this pref flip. We will send an official sign-off mail later this week, probably on Thursday.
Flags: needinfo?(bogdan.maris)
Okay, thanks bogdan_maris! Let's do it!
Keywords: checkin-needed
Assignee: nobody → mlongaray
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
The review request requires a r+ to be landed.
Flags: needinfo?(mconley)
Comment on attachment 8939604 [details]
Bug 1427809 - Enable Simplify Print Feature by default on Linux.

Whoops - thought I'd done that already. Thanks!
Flags: needinfo?(mconley)
Attachment #8939604 - Flags: review+
I meant an review+ on reviewboard, so the "Land Commits" menu item becomes activated :)
Flags: needinfo?(mconley)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/455b5ac2ac63
Enable Simplify Print Feature by default on Linux. r=mconley
Keywords: checkin-needed
Flags: needinfo?(mconley)
https://hg.mozilla.org/mozilla-central/rev/455b5ac2ac63
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.