Closed Bug 1427830 Opened 2 years ago Closed 2 years ago

Crash in mozilla::gfx::VRThread::PostDelayedTask

Categories

(Core :: WebVR, defect, critical)

Unspecified
Windows 8
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- fixed

People

(Reporter: marcia, Assigned: daoshengmu)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is
report bp-1ffcdac5-83af-4b05-beca-1470b0171227.
=============================================================

Seen while looking at nightly crash data: http://bit.ly/2EPpuKj. 17 crashes/6 installs on Windows 10 and Win 8.1

Adding daosheng since he works in this area.

Top 10 frames of crashing thread:

0 xul.dll mozilla::gfx::VRThread::PostDelayedTask gfx/vr/VRThread.cpp:190
1 xul.dll mozilla::gfx::VRThread::PostTask gfx/vr/VRThread.cpp:178
2 xul.dll mozilla::gfx::impl::VROculusSession::Refresh gfx/vr/gfxVROculus.cpp:401
3 xul.dll mozilla::gfx::VRSystemManagerOculus::NotifyVSync gfx/vr/gfxVROculus.cpp:1577
4 xul.dll mozilla::gfx::VRManager::NotifyVsync gfx/vr/VRManager.cpp:208
5 xul.dll mozilla::layers::CompositorVsyncScheduler::DispatchVREvents gfx/layers/ipc/CompositorVsyncScheduler.cpp:360
6 xul.dll mozilla::detail::RunnableMethodImpl<mozilla::layers::CompositorVsyncScheduler*, void  xpcom/threads/nsThreadUtils.h:1192
7 xul.dll MessageLoop::DoWork ipc/chromium/src/base/message_loop.cc:535
8 xul.dll base::MessagePumpDefault::Run ipc/chromium/src/base/message_pump_default.cc:36
9 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:319

=============================================================
Flags: needinfo?(dmu)
Assignee: nobody → dmu
Flags: needinfo?(dmu)
Comment on attachment 8939712 [details]
Bug 1427830 - If VR submit thread is inactive in Oculus, don't post tasks;

https://reviewboard.mozilla.org/r/210024/#review215906

LGTM, Thanks!
Attachment #8939712 - Flags: review?(kgilbert) → review+
Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a23a953ca85
If VR submit thread is inactive in Oculus, don't post tasks; r=kip
https://hg.mozilla.org/mozilla-central/rev/6a23a953ca85
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.