Closed Bug 1427847 Opened 6 years ago Closed 6 years ago

Update strings for Firefox 58

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 58
Iteration:
59.4 - Jan 15
Tracking Status
firefox58 + fixed
firefox59 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

User Story

https://github.com/mozilla/activity-stream/compare/firefox-58b12...firefox-58b15

Attachments

(1 file)

Final locale check is January 10th, so we need to get this uplifted before then.
Priority: -- → P1
User Story: (updated)
Depends on: 1407228
For some context, the last export to mozilla-beta was over a month ago:

2017.12.02.1393-6aa2a91e
https://hg.mozilla.org/releases/mozilla-beta/file/tip/browser/extensions/activity-stream/install.rdf.in
gl, gn, si were added since december
Depends on: 1424292
User Story: (updated)
No longer depends on: 1407228
Track 58+ as update the Activity Stream strings for 58.
Comment on attachment 8939704 [details]
Bug 1427847 - Update strings for Firefox 58.

https://reviewboard.mozilla.org/r/210008/#review216346

Looks good!
Attachment #8939704 - Flags: review?(khudson) → review+
Comment on attachment 8939704 [details]
Bug 1427847 - Update strings for Firefox 58.

Approval Request Comment
[Feature/Bug causing the regression]: Activity Stream
[User impact if declined]: 73 locales with missing / partially translated strings
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Strings only changes
[String changes made/needed]: Yes, these are the translated strings from pontoon.
Attachment #8939704 - Flags: approval-mozilla-beta?
(In reply to Ed Lee :Mardak from comment #6)
> [String changes made/needed]: Yes, these are the translated strings from
> pontoon.

Note that this patch doesn't require l10n=XXX in the commit message, it doesn't touch .properties files, and localization happens outside of m-c. It's good to uplift from a l10n point of view.
Comment on attachment 8939704 [details]
Bug 1427847 - Update strings for Firefox 58.

Update strings of Activity Streams for 58. Beta58+.
Attachment #8939704 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Iteration: 1.26 → 59.4 - Jan 15
User Story: (updated)
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: