Closed Bug 1427865 Opened 3 years ago Closed 3 years ago

TB: Restore the dialogheader binding and its styling after the removal in bug 1419600

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 59.0

People

(Reporter: stefanh, Assigned: Paenglab)

References

Details

Attachments

(1 file)

dialogheader.patch
3.31 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review 
No description provided.
Bug 1419600 is already in autoland.

https://dxr.mozilla.org/comm-central/search?q=dialogheader+-path%3Aobj-x86 shows we use the dialogheader only in the account manager. This is why I added the CSS code in accountManage.css. We also don't use header-large. That's why I haven't added this code.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8939674 - Flags: review?(jorgk)
Comment on attachment 8939674 [details] [diff] [review]
dialogheader.patch

I have very little idea about his stuff, so I can at best rs this.

Does this need bug 1419600 to land first?
Attachment #8939674 - Flags: review?(jorgk) → review+
It's the blue header on the right in account manager. I tried my patch together with the binding still in m-c and it works. So you could land it without waiting for bug 1419600.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4821a86a55d2
Restore the dialogheader binding and its styling after the removal in bug 1419600. rs=jorgk
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 59.0
You need to log in before you can comment on or make changes to this bug.