1427892 - Keyboard shortcuts specific to the Tab tray

Status: VERIFIED FIXED

(Firefox for iOS :: Browser, enhancement, P2)

Description

[Farhan Patel [:farhan]]

on the iPad we can have special shortucts that are only for certain ViewControllers. 

This would be a great way to do some interesting new shortcuts for the TabTray. 


For example
- Left/Right arrow to switch between selected tab (the selected tab has a blue outline. Pressing left/right would move this)
- Enter to open the selected tab
- Be able to delete a tab

Comment 1

[James Hugman [:jhugman] [@jhugman]]

Discoverable: Command-Alt-Tab
From Safari on macOS: Command-Shift-\

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3640

Comment 3

[James Hugman [:jhugman] [@jhugman]]

PR landed was to get to the Tab Tray.

This bug 

  - arrows around the tab.
  — Delete, Cmd W — "Close Selected Tab"
  — Shift Cmd W — "Close All Tabs"
  — Enter — "Open Selected Tab"
  – Cmd T — "Open New Tab"

Comment 4

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3662

Comment 5

[James Hugman [:jhugman] [@jhugman]]

Merged in to master. 

Uplifted to v11.x 41b932e80

Comment 6

[Simon Basca [:SimonB]]

Verifying as fix on master 6672352af5. All the shortcuts from comment 3 and comment 1 are working as expected.

Comment 7

[Simon Basca [:SimonB]]

Verifying as fix on 11.0(9266).