Closed Bug 1427934 Opened 2 years ago Closed 2 years ago

Some fixes to test_seekToNextFrame.html

Categories

(Core :: Audio/Video: Playback, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(3 files)

No description provided.
Assignee: nobody → jwwang
Priority: -- → P5
Attachment #8939722 - Flags: review?(kaku)
Attachment #8939723 - Flags: review?(kaku)
Attachment #8939724 - Flags: review?(kaku)
Comment on attachment 8939722 [details]
Bug 1427934. P1 - make logging less verbose.

https://reviewboard.mozilla.org/r/210032/#review215672
Attachment #8939722 - Flags: review?(kaku) → review+
Attachment #8939723 - Flags: review?(kaku) → review+
Comment on attachment 8939723 [details]
Bug 1427934. P2 - disable dormant.

https://reviewboard.mozilla.org/r/210034/#review215670

We already have a mechanism to prevent going into DormantState once seekToNextFrame is engaged.
See bug 1401757 and code: https://searchfox.org/mozilla-central/rev/b24e6342d744c5a83fab5c15972e11eeb69d68e6/dom/media/MediaDecoderStateMachine.cpp#1599-1602

The modification here only prevents going into DormantState after the first frame is loaded, not sure how much it helps.
Comment on attachment 8939724 [details]
Bug 1427934. P3 - check v.ended before calling callSeekToNextFrame().

https://reviewboard.mozilla.org/r/210036/#review215674
Attachment #8939724 - Flags: review?(kaku) → review+
Comment on attachment 8939723 [details]
Bug 1427934. P2 - disable dormant.

https://reviewboard.mozilla.org/r/210034/#review215670

It is 'slightly' faster for the 1st seekToNextFrame which doesn't need to go through 'exiting dormant' and then 'seekToNextFrame'.
Thanks for the review.
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc5d3268e179
P1 - make logging less verbose. r=kaku
https://hg.mozilla.org/integration/autoland/rev/7dc54aff9e7e
P2 - disable dormant. r=kaku
https://hg.mozilla.org/integration/autoland/rev/f9d423919e3f
P3 - check v.ended before calling callSeekToNextFrame(). r=kaku
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/191b1802e928
P1 - make logging less verbose. r=kaku
https://hg.mozilla.org/mozilla-central/rev/f6ad3ada1068
P2 - disable dormant. r=kaku
https://hg.mozilla.org/mozilla-central/rev/584b1ba07318
P3 - check v.ended before calling callSeekToNextFrame(). r=kaku
You need to log in before you can comment on or make changes to this bug.