1428032 - Link Github PRs to Perfherder alerts

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement, P1)

Description

[Ionuț Goldan [:igoldan]]

Currently, Perherder can only link perf alerts to Bugzilla bugs.
It should be able to do this with Github PRs as well.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3211

Comment 2

[Robert Wood [:rwood]]

Comment on attachment 8949773 [details]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3211

Thanks Ionut. Feedback given in the PR.

Note: I think you can just leave the attachment details as their default and just set the feedback or review flag as needed.

Comment 3

[Ionuț Goldan [:igoldan]]

Comment on attachment 8949773 [details]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3211

Can you please review this?

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8949773 [details]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3211

Left comments in PR

Comment 5

[Ionuț Goldan [:igoldan]]

Comment on attachment 8949773 [details]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3211

I addressed your comments. I prepared the ORM class, but don't actually make real use of it. I'm still using the hardcoded *.js values.

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/0badc9ec5f8f2ab7041b48f87c4ff94015146011
Bug 1428032 - Allow linking Perfherder alerts to Servo GitHub PRs (#3211)

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

can we close this bug?

Comment 8

[Ed Morley [:emorley]]

Could you file the bug for that followup?

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

I am unable to assign bugs on perfherder to alerts- this looks to be related, I see this in the console:
Possibly unhandled rejection: {"data":{"issue_tracker":["Invalid pk \"1\" - object does not exist."]},"status":400,"config":{"method":"PUT","transformRequest":[null],"transformResponse":[null],"jsonpCallbackParam":"callback","url":"/api/performance/alertsummary/11672/","data":{"bug_number":1435648,"issue_tracker":1},"headers":{"Accept":"application/json, text/plain, */*","Content-Type":"application/json;charset=utf-8","X-CSRFToken":"YA2JMzVzJall5nx0vLWsNN9fPnsP2FjSUVlTswrIXxo40NjzOEyEDG7As4LvDiiS"}},"statusText":"Bad Request","xhrStatus":"complete"}

I know :igolden is out today- I am not sure if we need to add some keys to a database for the issue_tracker field to resolve properly?

Comment 10

[William Lachance (:wlach)]

(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #9)
> I am unable to assign bugs on perfherder to alerts- this looks to be
> related, I see this in the console:
> Possibly unhandled rejection: {"data":{"issue_tracker":["Invalid pk \"1\" -
> object does not
> exist."]},"status":400,"config":{"method":"PUT","transformRequest":[null],
> "transformResponse":[null],"jsonpCallbackParam":"callback","url":"/api/
> performance/alertsummary/11672/","data":{"bug_number":1435648,
> "issue_tracker":1},"headers":{"Accept":"application/json, text/plain,
> */*","Content-Type":"application/json;charset=utf-8","X-CSRFToken":
> "YA2JMzVzJall5nx0vLWsNN9fPnsP2FjSUVlTswrIXxo40NjzOEyEDG7As4LvDiiS"}},
> "statusText":"Bad Request","xhrStatus":"complete"}
> 
> I know :igolden is out today- I am not sure if we need to add some keys to a
> database for the issue_tracker field to resolve properly?

See bug 1440691. I have a pull request pending, will ask for review when verified that it's passing tests etc.

Comment 11

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3266

Comment 12

[Ed Morley [:emorley]]

Comment on attachment 8953937 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3266

Many thanks :-)

Comment 13

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/bab66d806693f2051cb3d56da75b9f68981512f6
Bug 1428032 - Docs: Grant visibility for new issue_tracker table (#3266)

Comment 14

[Ed Morley [:emorley]]

I've run this against production:
GRANT SELECT ON treeherder.issue_tracker to 'redash';
GRANT SELECT ON treeherder.issue_tracker to 'activedata';
GRANT SELECT ON treeherder.issue_tracker to 'sclements';
GRANT SELECT ON treeherder.issue_tracker to 'igoldan';

Comment 15

[Ionuț Goldan [:igoldan]]

(In reply to Ed Morley (away until 3rd April) [:emorley] from comment #8)
> Could you file the bug for that followup?

Yes, I filed bug 1443772 for that.