Closed Bug 1428043 Opened 2 years ago Closed 2 years ago
missing file: resource://gre/modules/systemlibs
.js referenced from resource://devtools/shared/discovery/discovery .js
59 bytes, text/x-review-board-request
The browser_all_files_referenced.js test has this line in its output: missing file: resource://gre/modules/systemlibs.js referenced from resource://devtools/shared/discovery/discovery.js https://searchfox.org/mozilla-central/rev/b24e6342d744c5a83fab5c15972e11eeb69d68e6/devtools/shared/discovery/discovery.js#60-63 seems to be dead code
I don't know the code at all, but this does look unused. So, here's a simple patch that just removes the import.
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8939862 [details] Bug 1428043 - Remove useless systemlibs.js import; https://reviewboard.mozilla.org/r/210174/#review215930 Thanks! The usage code was B2G only, and it seems like it was removed in a mega-patch to remove B2G things in bug 1389598.
Attachment #8939862 - Flags: review?(jryans) → review+
Thanks Ryan. I pushed to TRY but most probably based on a bad commit because a lot of tests fail. Looks like they all fail after this assertion failure: GECKO(2327) | Assertion failure: !clasp->isProxy(), at /builds/worker/workspace/build/src/js/src/vm/Shape.h:122 So I'm gonna go ahead and push this to autoland.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/700a5ee41c95 Remove useless systemlibs.js import; r=jryans
You need to log in before you can comment on or make changes to this bug.