Closed Bug 1428048 Opened 2 years ago Closed 2 years ago

browser/modules/CastingApps.jsm is dead code

Categories

(Firefox :: General, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: florian, Assigned: anazarkin1, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(2 files)

Bug 1393582 removed CastingApps.jsm from the browser/modules/moz.build file, but didn't actually remove the browser/modules/CastingApps.jsm file.

And it's still referenced at https://searchfox.org/mozilla-central/rev/b24e6342d744c5a83fab5c15972e11eeb69d68e6/browser/modules/ContextMenu.jsm#20, which is how I found this, in the browser_all_files_referenced.js output:
missing file: resource:///modules/CastingApps.jsm referenced from resource://app/modules/ContextMenu.jsm
Keywords: good-first-bug
Priority: -- → P3
I'd like to work on this.
(In reply to juwang321 from comment #1)
> I'd like to work on this.

Thanks! Are you familiar with the contribution process? You can find more info here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction

The task in this bug is fairly simple: Delete the CastingApps.jsm file and its single occurrence:

https://searchfox.org/mozilla-central/search?q=CastingApps.jsm&path=

Let me know if you have any more questions!
Assignee: nobody → juwang321
Mentor: jhofmann
Status: NEW → ASSIGNED
Hey there, are you still interested in working on this? I'll unassign you for now, let me know if you'd still like to tackle this bug!
Assignee: juwang321 → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(juwang321)
Hi there, I'd like to take on this bug if it's still available? Thanks!
Comment on attachment 8955555 [details]
Bug 1428048 - Remove dead code browser/modules/CastingApps.jsm and its reference;

https://reviewboard.mozilla.org/r/224700/#review230702

Looks good to me, thanks!
Attachment #8955555 - Flags: review?(florian) → review+
CastingApps.jsm was removed from browser/modules/moz.build file in bug 1393582, but
the file itself and its usage was not removed from ContextMenu.jsm

MozReview-Commit-ID: DsqJTPP66xE
Assignee: nobody → anazarkin1
Status: NEW → ASSIGNED
Comment on attachment 8955555 [details]
Bug 1428048 - Remove dead code browser/modules/CastingApps.jsm and its reference;

https://reviewboard.mozilla.org/r/224700/#review230754

I think Florian's r+ should be enough, I can land this for you, though :)
Attachment #8955555 - Flags: review?(jhofmann)
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2dfee3d72b6c
Remove dead code browser/modules/CastingApps.jsm and its reference; r=florian
Comment on attachment 8955555 [details]
Bug 1428048 - Remove dead code browser/modules/CastingApps.jsm and its reference;

https://reviewboard.mozilla.org/r/224700/#review230754

Thanks Johann, that would be great!
Flags: needinfo?(juwang321)
https://hg.mozilla.org/mozilla-central/rev/2dfee3d72b6c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.