1428048 - browser/modules/CastingApps.jsm is dead code

Status: RESOLVED FIXED

(Firefox :: General, defect, P3)

Description

[Florian Quèze [:florian]]

Bug 1393582 removed CastingApps.jsm from the browser/modules/moz.build file, but didn't actually remove the browser/modules/CastingApps.jsm file.

And it's still referenced at https://searchfox.org/mozilla-central/rev/b24e6342d744c5a83fab5c15972e11eeb69d68e6/browser/modules/ContextMenu.jsm#20, which is how I found this, in the browser_all_files_referenced.js output:
missing file: resource:///modules/CastingApps.jsm referenced from resource://app/modules/ContextMenu.jsm

Comment 1

[juwang321]

I'd like to work on this.

Comment 2

[Johann Hofmann [:johannh]]

(In reply to juwang321 from comment #1)
> I'd like to work on this.

Thanks! Are you familiar with the contribution process? You can find more info here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction

The task in this bug is fairly simple: Delete the CastingApps.jsm file and its single occurrence:

https://searchfox.org/mozilla-central/search?q=CastingApps.jsm&path=

Let me know if you have any more questions!

Comment 3

[Johann Hofmann [:johannh]]

Hey there, are you still interested in working on this? I'll unassign you for now, let me know if you'd still like to tackle this bug!

Comment 4

[Aleksandr]

Hi there, I'd like to take on this bug if it's still available? Thanks!

Comment 5

[Aleksandr]

Attachment: Bug 1428048 - Remove dead code browser/modules/CastingApps.jsm and its reference;

CastingApps.jsm was removed from browser/modules/moz.build file in bug 1393582, but
the file itself and its usage was not removed from ContextMenu.jsm

Review commit: https://reviewboard.mozilla.org/r/224700/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224700/

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 8955555 [details]
Bug 1428048 - Remove dead code browser/modules/CastingApps.jsm and its reference;

https://reviewboard.mozilla.org/r/224700/#review230702

Looks good to me, thanks!

Comment 7

[Aleksandr]

Attachment: Remove dead code browser/modules/CastingApps.jsm and its reference; johannh

CastingApps.jsm was removed from browser/modules/moz.build file in bug 1393582, but
the file itself and its usage was not removed from ContextMenu.jsm

MozReview-Commit-ID: DsqJTPP66xE

Comment 8

[Johann Hofmann [:johannh]]

Comment on attachment 8955555 [details]
Bug 1428048 - Remove dead code browser/modules/CastingApps.jsm and its reference;

https://reviewboard.mozilla.org/r/224700/#review230754

I think Florian's r+ should be enough, I can land this for you, though :)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dfee3d72b6c
Remove dead code browser/modules/CastingApps.jsm and its reference; r=florian

Comment 10

[Aleksandr]

Comment on attachment 8955555 [details]
Bug 1428048 - Remove dead code browser/modules/CastingApps.jsm and its reference;

https://reviewboard.mozilla.org/r/224700/#review230754

Thanks Johann, that would be great!

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/2dfee3d72b6c