Closed Bug 1428075 Opened 6 years ago Closed 6 years ago

SavedFrame::Iterator and ConstIterator are not GC safe and are only used by test code

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

We should remove them as they are potential GC hazards and change the test code to use SavedFrame::RootedRange and RootedIterator.
Attachment #8939874 - Flags: review?(sphink)
Comment on attachment 8939874 [details] [diff] [review]
bug1428075-remove-saved-frame-iters

Review of attachment 8939874 [details] [diff] [review]:
-----------------------------------------------------------------

Huh, I thought that there was some place where I was iterating over them in a no-gc context, and it didn't make sense to root them. But if this patch is green, then that obviously isn't the case. LGTM!
Attachment #8939874 - Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/134e8f9868a1
Remove non-rooted saved frame iterators r=fitzgen
https://hg.mozilla.org/mozilla-central/rev/134e8f9868a1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: