1428094 - Exception raised from a webRequest blocking listener should report the original error message and filename

Status: VERIFIED FIXED

(WebExtensions :: Request Handling, defect, P3)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

When a blocking listener raises an exception, the raised exception is currently reported as "[Object]", instead of being reported with the exception error message and stack trace.

e.g. the multi-account-containers exception is currently experiencing this issue (https://github.com/mozilla/multi-account-containers) and the following error message is logged in the browser console:

```
[object Object] WebRequest.jsm:806
	applyChanges resource://gre/modules/WebRequest.jsm:806:13
	throw self-hosted:1203:9
```

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1428094 - Exception raised from a webRequest blocking listener should report the original error message and filename.

Review commit: https://reviewboard.mozilla.org/r/210202/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210202/

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8939893 [details]
Bug 1428094 - Exception raised from a webRequest blocking listener should report the original error message and filename.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210202/diff/1-2/

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8939893 [details]
Bug 1428094 - Exception raised from a webRequest blocking listener should report the original error message and filename.

https://reviewboard.mozilla.org/r/210202/#review216896

::: toolkit/components/extensions/test/mochitest/test_ext_webrequest_suspend.html:262
(Diff revision 2)
> +
> +      browser.test.sendMessage("background-ready");
> +    },
> +  });
> +
> +  // TODO(rpl): this could use the chrome console helpers

use "TODO BUG #: comment" for followups

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8939893 [details]
Bug 1428094 - Exception raised from a webRequest blocking listener should report the original error message and filename.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210202/diff/2-3/

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8939893 [details]
Bug 1428094 - Exception raised from a webRequest blocking listener should report the original error message and filename.

https://reviewboard.mozilla.org/r/210202/#review216896

> use "TODO BUG #: comment" for followups

Bug 1417639 has been landed and merged to mozilla-central, and so I've just rebased this PR and rewritten this part to use the consoleMonitor helper from Bug 1417639 (and so I removed the TODO completely, which is even better :-)).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef1b83a2f4f4
Exception raised from a webRequest blocking listener should report the original error message and filename. r=mixedpuppy

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ef1b83a2f4f4

Comment 8

[CosminB]

Attachment: Bug1428094.png

I can reproduce this issue on Firefox 57.0.4 (20180103231032) under Win 7 64-bit and Mac OS X 10.13

This issue is verified as fixed on Firefox 59.0a1 (20180115100056) under Win 7 64-bit and Mac OS X 10.13

Please see the attached screenshot.