Closed
Bug 1428100
Opened 7 years ago
Closed 7 years ago
"Get Map" button visible even if only a web page is added
Categories
(Thunderbird :: Address Book, defect)
Thunderbird
Address Book
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 59.0
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
|
2.15 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
If you enter a home or work web page (also works with a couple of other fields) then the Get Map button remains visible and takes you to the map for the last contact with map data. It should probably disappear if there is no map data.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8939895 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8939895 [details] [diff] [review]
1428100.diff
Review of attachment 8939895 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM, thx! r=mkmelin
Attachment #8939895 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Updated•7 years ago
|
Assignee: nobody → neil
|
|
Assignee | |
Updated•7 years ago
|
Whiteboard: needs-landing
|
||
Comment 3•7 years ago
|
||
With c-n Jörg will find this bug easier for landing.
Keywords: checkin-needed
Whiteboard: needs-landing
|
||
Comment 4•7 years ago
|
||
Neil is back and fixing thinks, yay! (but he forgot how to do a proper patch with user, etc. I'll fix it)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/ea396b8000c3
"Get Map" button visible even if only a web page is added. r=mkmelin
|
|
||
Comment 6•7 years ago
|
||
Of course that was meant to be "... and fixing things".
Target Milestone: --- → Thunderbird 59.0
You need to log in
before you can comment on or make changes to this bug.
Description
•