142814 - ToolTips not implemented in PPEmbed

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: Mac, defect)

Description

[Conrad Carlen (not reading bugmail)]

Summary says it all - patch coming soon.

Comment 1

[Conrad Carlen (not reading bugmail)]

Attachment: patch

Uses the Carbon Help mgr, which makes really lovely tooltips on OS X, makes the
methods virtual in case somebody wanted something else.

Pink, can you r=?

Comment 2

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 82658 [details] [diff] [review]
patch

nice. r=pink. shouldn't the "show tooltip" code in gecko be filtering out
chrome tooltips rather than CBrowserShell?

Comment 3

[Conrad Carlen (not reading bugmail)]

> shouldn't the "show tooltip" code in gecko be filtering out
chrome tooltips rather than CBrowserShell?

I think so. Something must be doing that somewhere in the browser
(non-embedded). Either the tooltips should be filtered or at least have some
useful content. In testing, in the prefs dialog, I found that a tooltip kept
popping up, no matter where the mouse was, which just said "Preferences"

Any idea where a bug should go or who to ask about the content of tooltips in
XUL dialogs?

Comment 4

[Conrad Carlen (not reading bugmail)]

CC'ing scc for sr=

Comment 5

[Conrad Carlen (not reading bugmail)]

BTW, because of using HMHideTag(), this is no longer buildable with the
Universal Interfaces (3.4) which came with CW 7.0. It now requires the current
standard mozilla build environment (Universal Interfaces 3.4.1 and CarbonLib
1.5) CarbonLib 1.2 should be enough but can't say for certain. 

Comment 6

[Conrad Carlen (not reading bugmail)]

Attachment: better patch

In the old patch, code in PPEmbed ignored requests for tool tips in chrome
windows. I changed the default tool tip text provider to not get the text from
certain element types. Need review.

Comment 7

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 82825 [details] [diff] [review]
better patch

+      if (!elemTag.Equals(tag_dialog) &&
+	   !elemTag.Equals(tag_dialogheader) &&
+	   !elemTag.Equals(tag_window)) {

rather than take the hit of 3 string compares here every time, I'd rather you
used nsIContent's version of GetTagName which supports atoms instead of
strings. Then we're down to 3 ptr compares instead of 3 string compares

Comment 8

[Conrad Carlen (not reading bugmail)]

Attachment: using atoms

3rd time's the charm?

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 82855 [details] [diff] [review]
using atoms

r=pink

Comment 10

[Conrad Carlen (not reading bugmail)]

*** Bug 145149 has been marked as a duplicate of this bug. ***

Comment 11

[Patrick C. Beard]

Comment on attachment 82855 [details] [diff] [review]
using atoms

Use |NS_IMETHOD|, not |virtual NS_METHOD|.

The following leaks reference counts:

+    mTag_dialog       = NS_NewAtom("dialog");
+    mTag_dialogheader = NS_NewAtom("dialogheader");
+    mTag_window       = NS_NewAtom("window");	 

You need to wrap each call with |getter_AddRefs()|.

Comment 12

[Conrad Carlen (not reading bugmail)]

Attachment: addresses Patrick's comments

need sr=.

Comment 13

[Conrad Carlen (not reading bugmail)]

Comment on attachment 84345 [details] [diff] [review]
addresses Patrick's comments

Forwarding Pink's r=.

Comment 14

[Patrick C. Beard]

Comment on attachment 84345 [details] [diff] [review]
addresses Patrick's comments

sr=beard

Comment 15

[Mike Pinkerton (not reading bugmail)]

landed on trunk. needs adt/a= so embedding apps that want to use the branch as a
sample for mac tooltip code get the goodness.

Comment 16

[Chris Petersen]

Awesome.... Verified on OS X PP Embed trunk 2002-05-29-08

Comment 17

[Judson Valeski]

please land on the 1.0.1 branch ASAP. once landed, please remove the
mozilla1.0.1+ keyword and add the fixed1.0.1 keyword.

Comment 18

[scottputterman]

adding adt1.0.1+.  Please check into the branch as soon as possible.

Comment 19

[Mike Pinkerton (not reading bugmail)]

landed on trunk and branch.

Comment 20

[Chris Petersen]

Verified on PPEmbed branch (2002-06-05-05 1.0.0)