Closed
Bug 1428142
Opened 2 years ago
Closed 2 years ago
Update to cbindgen:0.3.3
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Core
Graphics: WebRender
P1
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: rhunt, Assigned: rhunt)
References
Details
Attachments
(2 files)
13.64 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
17.83 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
The generic_type_specialization key was dropped in favor of direct template creation after version 0.2.2 and that prevents us from using new cbindgen versions. I have patches that update the bindings and fixup the things that break.
Assignee | ||
Comment 1•2 years ago
|
||
Attachment #8939928 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 2•2 years ago
|
||
I'll squash and add the bug number to these when landing.
Attachment #8939929 -
Flags: review?(nical.bugzilla)
Comment 3•2 years ago
|
||
Comment on attachment 8939928 [details] [diff] [review] cbindgen-1.patch Review of attachment 8939928 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8939928 -
Flags: review?(nical.bugzilla) → review+
Updated•2 years ago
|
Attachment #8939929 -
Flags: review?(nical.bugzilla) → review+
Pushed by rhunt@eqrion.net: https://hg.mozilla.org/integration/mozilla-inbound/rev/c5f975c4bfc7 Generate webrender_ffi_generated with cbindgen:0.3.3 (bug 1428142, r=nical)
Updated•2 years ago
|
Blocks: stage-wr-nightly
Priority: -- → P1
![]() |
||
Comment 5•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c5f975c4bfc7
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•