Flatten SeaMonkey suite/shell structure and move to components/

RESOLVED FIXED in seamonkey2.57

Status

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Tracking

Trunk
seamonkey2.57
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Posted patch shell_flatten.diff (obsolete) — Splinter Review
There are a number of areas in SeaMonkey which are unnecessarily deep, one such area is suite/shell
Attachment #8939936 - Flags: review?(frgrahl)
Comment on attachment 8939936 [details] [diff] [review]
shell_flatten.diff

Looks fine to me. How about moving it to components\shell instead of just shell like in browser\components\shell? When I need to look up something in browser or vice versa in suite I most often need to figure out the correct location first. And with the latest gecko changes we probably need to take a lot of stuff from browser in the future anyway so 1:1 would make sense.

r+ either way.
Attachment #8939936 - Flags: review?(frgrahl) → review+
Summary: Flatten SeaMonkey suite/shell structure → Flatten SeaMonkey suite/shell structure and move to components/
Posted patch shell_flatten_v2.diff (obsolete) — Splinter Review
Changes since last patch:
* Move into components/ sub directory
* Picked up a missing change to suite/build/moz.build

Re-requesting r+ to make sure correct route has been taken
Attachment #8939936 - Attachment is obsolete: true
Attachment #8940111 - Flags: review?(frgrahl)
Add bug number and description to the patch
Attachment #8940111 - Attachment is obsolete: true
Attachment #8940111 - Flags: review?(frgrahl)
Attachment #8940147 - Flags: review?(frgrahl)
Blocks: 1428303
Blocks: 1428299, 1428149
Pushed by iann_cvs@blueyonder.co.uk:
https://hg.mozilla.org/comm-central/rev/2f4c545ecc13
Flatten SeaMonkey suite/shell structure and move to components/ r=frg
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Comment on attachment 8940147 [details] [diff] [review]
shell_flatten_v2.diff [Checked in: Comment 5]

Carrying forward r+
https://hg.mozilla.org/comm-central/rev/2f4c545ecc13d1e401de11ce14d65be7945b32b2
Attachment #8940147 - Attachment description: shell_flatten_v2.diff → shell_flatten_v2.diff [Checked in: Comment 4]
Attachment #8940147 - Flags: review?(frgrahl) → review+
Attachment #8940147 - Attachment description: shell_flatten_v2.diff [Checked in: Comment 4] → shell_flatten_v2.diff [Checked in: Comment 5]
Target Milestone: --- → Seamonkey2.57
You need to log in before you can comment on or make changes to this bug.