1428185 - Followup to bug 1417678 - remove en-US US and CA entries in list.json

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Mike Kaply [:mkaply]]

For en-US, US and CA are handed by regionOverrides. I should have removed them from list.json.

Comment 1

[Mike Kaply [:mkaply]]

[Tracking Requested - why for this release]: This is needed as part of the new search work.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bug 1428185 - regionOverrides handles US/CA for en-US.

Review commit: https://reviewboard.mozilla.org/r/210260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210260/

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8939983 [details]
Bug 1428185 - regionOverrides handles US/CA for en-US.

https://reviewboard.mozilla.org/r/210260/#review216004

I'm not a reviewer for mobile/ but this seems trivial enough that I can r+.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99ceea34ba02
regionOverrides handles US/CA for en-US. r=florian

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/99ceea34ba02

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 8939983 [details]
Bug 1428185 - regionOverrides handles US/CA for en-US.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1428185
[User impact if declined]: Possible incorrect search engine codes
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Low
[Why is the change risky/not risky?]: Removes code that shouldn't have been there.
[String changes made/needed]: None

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8939983 [details]
Bug 1428185 - regionOverrides handles US/CA for en-US.

Take this to avoid possible incorrect search engine codes. Beta58+.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/8c014d799aa4

Comment 9

[Adrian Florinescu [:aflorinescu]]

I've added the qe verify flag by mistake; removing as such.