Closed Bug 1428185 Opened 4 years ago Closed 4 years ago

Followup to bug 1417678 - remove en-US US and CA entries in list.json

Categories

(Firefox for Android Graveyard :: Search Activity, defect)

Firefox 57
defect
Not set
normal

Tracking

(firefox58- fixed, firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox58 - fixed
firefox59 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file)

For en-US, US and CA are handed by regionOverrides. I should have removed them from list.json.
[Tracking Requested - why for this release]: This is needed as part of the new search work.
Comment on attachment 8939983 [details]
Bug 1428185 - regionOverrides handles US/CA for en-US.

https://reviewboard.mozilla.org/r/210260/#review216004

I'm not a reviewer for mobile/ but this seems trivial enough that I can r+.
Attachment #8939983 - Flags: review?(florian) → review+
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/99ceea34ba02
regionOverrides handles US/CA for en-US. r=florian
https://hg.mozilla.org/mozilla-central/rev/99ceea34ba02
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Comment on attachment 8939983 [details]
Bug 1428185 - regionOverrides handles US/CA for en-US.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1428185
[User impact if declined]: Possible incorrect search engine codes
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Low
[Why is the change risky/not risky?]: Removes code that shouldn't have been there.
[String changes made/needed]: None
Attachment #8939983 - Flags: approval-mozilla-beta?
Comment on attachment 8939983 [details]
Bug 1428185 - regionOverrides handles US/CA for en-US.

Take this to avoid possible incorrect search engine codes. Beta58+.
Attachment #8939983 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
I've added the qe verify flag by mistake; removing as such.
Flags: qe-verify+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.