1428197 - repack_rust.py should reject generic channels

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

As the problems from the release of 1.24.0-beta.1 showed (see https://hg.mozilla.org/integration/mozilla-inbound/rev/c1e20de19b6f), using a generic channel name (e.g. "stable", "beta", "nightly") for repack_rust.py should be an error.

Comment 1

[Mike Hommey [:glandium]]

Note that https://hg.mozilla.org/integration/mozilla-inbound/rev/5afa32a16a2f allowed for a specific version of a beta to be specified. I also filed https://github.com/rust-lang-nursery/rustup.rs/issues/1329 to make that easier.

Comment 2

[Ralph Giles (:rillian)]

Attachment: Bug 1428197 - Reject generic channels in rust repack jobs.

Ensure better determinism when crating rust toolchain packages
by rejecting generic channels like 'stable' or 'nightly'. Instead,
insist on a specific version or date.

The current valid dates for beta and nightly can be obtained with:

curl -s https://static.rust-lang.org/dist/channel-rust-beta.toml | grep ^date
curl -s https://static.rust-lang.org/dist/channel-rust-nightly.toml | grep ^date

Review commit: https://reviewboard.mozilla.org/r/223400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223400/

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8954247 [details]
Bug 1428197 - Reject generic channels in rust repack jobs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223400/diff/1-2/

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8954247 [details]
Bug 1428197 - Reject generic channels in rust repack jobs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223400/diff/2-3/

Comment 5

[Ralph Giles (:rillian)]

Try push verifying we reject generic channels:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8ab80cff49c4741042ef0001ba999bfb3128959

Try push verifying we accept a dated beta channel:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5634b0a97746dbce34b01f7f00f6886a14408875

Flake8 lints are fixed in the revised patch.

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8954247 [details]
Bug 1428197 - Reject generic channels in rust repack jobs.

https://reviewboard.mozilla.org/r/223400/#review230532

::: taskcluster/scripts/misc/repack_rust.py:390
(Diff revision 3)
>  
>  
> +def validate_channel(channel):
> +    '''Require a specific release version.
> +
> +    Packaging on of the meta-channels, like `stable`, `beta`,

on of?

::: taskcluster/scripts/misc/repack_rust.py:394
(Diff revision 3)
> +
> +    Packaging on of the meta-channels, like `stable`, `beta`,
> +    or `nightly` doesn't give repeatable output. Reject such
> +    channels.'''
> +    channel_prefixes = ('stable', 'beta', 'nightly')
> +    if any([c in channel for c in channel_prefixes]):

maybe channel.startswith(c)?

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8954247 [details]
Bug 1428197 - Reject generic channels in rust repack jobs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223400/diff/3-4/

Comment 8

[Ralph Giles (:rillian)]

Comment on attachment 8954247 [details]
Bug 1428197 - Reject generic channels in rust repack jobs.

https://reviewboard.mozilla.org/r/223400/#review230532

> on of?

Oops. Replaced with "from".

> maybe channel.startswith(c)?

Ok.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c41c9cc44d8a
Reject generic channels in rust repack jobs. r=glandium

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c41c9cc44d8a