Closed Bug 1428197 Opened 2 years ago Closed 2 years ago

repack_rust.py should reject generic channels

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: glandium, Assigned: rillian)

Details

Attachments

(1 file)

As the problems from the release of 1.24.0-beta.1 showed (see https://hg.mozilla.org/integration/mozilla-inbound/rev/c1e20de19b6f), using a generic channel name (e.g. "stable", "beta", "nightly") for repack_rust.py should be an error.
Note that https://hg.mozilla.org/integration/mozilla-inbound/rev/5afa32a16a2f allowed for a specific version of a beta to be specified. I also filed https://github.com/rust-lang-nursery/rustup.rs/issues/1329 to make that easier.
Try push verifying we reject generic channels:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8ab80cff49c4741042ef0001ba999bfb3128959

Try push verifying we accept a dated beta channel:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5634b0a97746dbce34b01f7f00f6886a14408875

Flake8 lints are fixed in the revised patch.
Comment on attachment 8954247 [details]
Bug 1428197 - Reject generic channels in rust repack jobs.

https://reviewboard.mozilla.org/r/223400/#review230532

::: taskcluster/scripts/misc/repack_rust.py:390
(Diff revision 3)
>  
>  
> +def validate_channel(channel):
> +    '''Require a specific release version.
> +
> +    Packaging on of the meta-channels, like `stable`, `beta`,

on of?

::: taskcluster/scripts/misc/repack_rust.py:394
(Diff revision 3)
> +
> +    Packaging on of the meta-channels, like `stable`, `beta`,
> +    or `nightly` doesn't give repeatable output. Reject such
> +    channels.'''
> +    channel_prefixes = ('stable', 'beta', 'nightly')
> +    if any([c in channel for c in channel_prefixes]):

maybe channel.startswith(c)?
Attachment #8954247 - Flags: review?(mh+mozilla) → review+
Product: Core → Firefox Build System
Comment on attachment 8954247 [details]
Bug 1428197 - Reject generic channels in rust repack jobs.

https://reviewboard.mozilla.org/r/223400/#review230532

> on of?

Oops. Replaced with "from".

> maybe channel.startswith(c)?

Ok.
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c41c9cc44d8a
Reject generic channels in rust repack jobs. r=glandium
https://hg.mozilla.org/mozilla-central/rev/c41c9cc44d8a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.