1428289 - Release mozversion 1.5

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Some of the latest mozlog changes seem to have broken mozversion:

$ virtualenv venv
$ . venv/bin/activate
(venvtest) $ pip install mozversion
Collecting mozversion
Collecting mozfile>=1.0 (from mozversion)
Collecting mozlog>=3.0 (from mozversion)
  Downloading mozlog-3.6-py2-none-any.whl (58kB)
    100% |################################| 61kB 730kB/s
Collecting blessings>=1.3 (from mozlog>=3.0->mozversion)
  Downloading blessings-1.6.1-py2-none-any.whl
Installing collected packages: mozfile, blessings, mozlog, mozversion
Successfully installed blessings-1.6.1 mozfile-1.2 mozlog-3.6 mozversion-1.4
(venvtest) $ mozversion /Applications/FirefoxNightly.app
Traceback (most recent call last):
  File "/usr/local/bin/mozversion", line 9, in <module>
    load_entry_point('mozversion', 'console_scripts', 'mozversion')()
  File "/usr/local/lib/python2.7/site-packages/mozversion/mozversion.py", line 319, in cli
    structured.commandline.add_logging_group(
NameError: global name 'structured' is not defined

Andrew, given that you did a bit of work in that area, can you please check? This regression blocks me because it also affects consumers like marionette client. Thanks

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Wow, this was fixed already 2 years ago via bug 1218373, but we never released a new version to PyPI. Lets get a new release out!

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1428289 - Release mozversion 1.5.

Review commit: https://reviewboard.mozilla.org/r/210394/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210394/

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8940110 [details]
Bug 1428289 - Release mozversion 1.5.

https://reviewboard.mozilla.org/r/210394/#review216134

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f651c2c5b21
Release mozversion 1.5. r=jmaher

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6f651c2c5b21

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I still have to release the bits to PyPI. Will do it later today.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Uploading distributions to https://upload.pypi.org/legacy/
Uploading mozversion-1.5-py2-none-any.whl
Uploading mozversion-1.5.tar.gz