Move SeaMonkey suite/build to components/

RESOLVED FIXED in seamonkey2.57

Status

enhancement
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Tracking

Trunk
seamonkey2.57
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
Move suite/build into components/ to join the rest of the code that builds FINAL_LIBRARY = 'suite'
Assignee

Updated

2 years ago
OS: Unspecified → All
Hardware: Unspecified → All
Assignee

Comment 1

2 years ago
This patch:
* Moves suite/build to components/
Attachment #8940166 - Flags: review?(frgrahl)
Assignee

Updated

2 years ago
Depends on: 1428148, 1428149, 1428299

Comment 2

2 years ago
build/ in all products has always been intentionally at the top level, and not even sure if some build system stuff even expected or expects that.

All that said, components has been deprecated for years already and things should actually be put to the toplevel, even the components/ subdirectory is IMHO too much depth.
Comment on attachment 8940166 [details] [diff] [review]
components_build.diff [Checked in: Comment 5]

Works fine after a rebase. Same for the dependent patches. Did Linux and Windows builds. f+ for now.

IanN could you check the ones I sent you and reupload them. I will r+ them then.

SeaMonkey is the odd man out here with suite/build so for porting patches a common structure makes it easier. All other products have a build dir in components. There is still a top level build dir which will not go away and is needed.

ewong do you think we could run into build problems with this?
Flags: needinfo?(ewong)
Attachment #8940166 - Flags: review?(frgrahl) → feedback+
(In reply to Frank-Rainer Grahl (:frg) from comment #3)

> SeaMonkey is the odd man out here with suite/build so for porting patches a
> common structure makes it easier. All other products have a build dir in
> components. There is still a top level build dir which will not go away and
> is needed.
> 
> ewong do you think we could run into build problems with this?

If there are going to be problems (which I doubt), I don't believe they 
will be terribly difficult to fix.  Ditto with the automation.
Flags: needinfo?(ewong)

Comment 5

Last year
Pushed by iann_cvs@blueyonder.co.uk:
https://hg.mozilla.org/comm-central/rev/6cf4a2d1662a
Move SeaMonkey suite/build to components/ r=frg
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Assignee

Comment 6

Last year
Comment on attachment 8940166 [details] [diff] [review]
components_build.diff [Checked in: Comment 5]

r+ from frg via IRC (from a few months ago)
Attachment #8940166 - Attachment description: components_build.diff → components_build.diff [Checked in: Comment 5]
Attachment #8940166 - Flags: review+
Assignee

Updated

Last year
Target Milestone: --- → Seamonkey2.57
See Also: → 1453046
You need to log in before you can comment on or make changes to this bug.