1428303 - Move SeaMonkey suite/build to components/

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, enhancement)

Description

[Ian Neal]

Move suite/build into components/ to join the rest of the code that builds FINAL_LIBRARY = 'suite'

Comment 1

[Ian Neal]

Attachment: components_build.diff [Checked in: Comment 5]

This patch:
* Moves suite/build to components/

Comment 2

[Robert Kaiser]

build/ in all products has always been intentionally at the top level, and not even sure if some build system stuff even expected or expects that.

All that said, components has been deprecated for years already and things should actually be put to the toplevel, even the components/ subdirectory is IMHO too much depth.

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8940166 [details] [diff] [review]
components_build.diff [Checked in: Comment 5]

Works fine after a rebase. Same for the dependent patches. Did Linux and Windows builds. f+ for now.

IanN could you check the ones I sent you and reupload them. I will r+ them then.

SeaMonkey is the odd man out here with suite/build so for porting patches a common structure makes it easier. All other products have a build dir in components. There is still a top level build dir which will not go away and is needed.

ewong do you think we could run into build problems with this?

Comment 4

[Edmund Wong (:ewong)]

(In reply to Frank-Rainer Grahl (:frg) from comment #3)

> SeaMonkey is the odd man out here with suite/build so for porting patches a
> common structure makes it easier. All other products have a build dir in
> components. There is still a top level build dir which will not go away and
> is needed.
> 
> ewong do you think we could run into build problems with this?

If there are going to be problems (which I doubt), I don't believe they 
will be terribly difficult to fix.  Ditto with the automation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6cf4a2d1662a
Move SeaMonkey suite/build to components/ r=frg

Comment 6

[Ian Neal]

Comment on attachment 8940166 [details] [diff] [review]
components_build.diff [Checked in: Comment 5]

r+ from frg via IRC (from a few months ago)