1428336 - Remove fallback border and background from the synced tabs sidebar's search field

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Dão Gottwald [:dao]]

As far as I can tell these are pointless, because -moz-appearance: searchfield suppresses any CSS border and background:

https://searchfox.org/mozilla-central/rev/652fbd6270de0d3ec424d2b88f8375ff546f949f/browser/themes/osx/syncedtabs/sidebar.css#109-119,133-139

Also, 'color' should be set to -moz-fieldText rather than #000.

Comment 1

[Archit Jugran]

Hey,could i be assigned this bug?  i am new to open source. I think i got a decent idea what to do in this bug, i need to delete lines from 109 to 119 . and replace #000 with   -moz-fieldText in lines 134 to 137

Comment 2

[Archit Jugran]

Attachment: I removed the unnecessary lines of code and changed the color field from #00000 to -moz-fieldText in the appropriate places

Please review my patch. Thank you

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8940472 [details] [diff] [review]
I removed the unnecessary lines of code and changed the color field from #00000 to  -moz-fieldText in the appropriate places

Hi! This is a good start, but needs a few adjustments. See below.

>--- a/browser/themes/osx/syncedtabs/sidebar.css
>+++ b/browser/themes/osx/syncedtabs/sidebar.css
>@@ -106,17 +106,6 @@
>   font-size: 12px;
>   cursor: text;
>   margin: 4px;
>-  border-width: 3px;
>-  border-style: solid;
>-  border-color: currentcolor;
>-  border-image: none;
>-  -moz-border-top-colors: transparent #888 #000;
>-  -moz-border-right-colors: transparent #FFF #000;
>-  -moz-border-bottom-colors: transparent #FFF #000;
>-  -moz-border-left-colors: transparent #888 #000;
>-  border-top-right-radius: 2px;
>-  border-bottom-left-radius: 2px;
>-  background-color: #FFF;
>   color: #000;

Need to use 'color: -moz-fieldText;' here.

> .search-box[focused="true"] {
>-  -moz-border-top-colors: -moz-mac-focusring -moz-mac-focusring #000000;
>-  -moz-border-right-colors: -moz-mac-focusring -moz-mac-focusring #000000;
>-  -moz-border-bottom-colors: -moz-mac-focusring -moz-mac-focusring #000000;
>-  -moz-border-left-colors: -moz-mac-focusring -moz-mac-focusring #000000;
>+  -moz-border-top-colors: -moz-mac-focusring -moz-mac-focusring -moz-fieldText;
>+  -moz-border-right-colors: -moz-mac-focusring -moz-mac-focusring -moz-fieldText;
>+  -moz-border-bottom-colors: -moz-mac-focusring -moz-mac-focusring -moz-fieldText;
>+  -moz-border-left-colors: -moz-mac-focusring -moz-mac-focusring -moz-fieldText;
> }

And this rule can completely go away.

Comment 4

[Archit Jugran]

I could not understand what you mean by "this rule can completely go away"

Comment 5

[Dão Gottwald [:dao]]

(In reply to Archit Jugran from comment #4)
> I could not understand what you mean by "this rule can completely go away"

You should remove the whole .search-box[focused="true"] rule.

Comment 6

[Dão Gottwald [:dao]]

Still unclear what I meant?

Comment 7

[Archit Jugran]

Thank you Dao...it is perfectly clear.. i will upload patch in a few hours..was very busy during the previous week. Thank you

Comment 8

[Archit Jugran]

Attachment: I removed the unnecessary lines of code and changed the color field from #00000 to -moz-fieldText in the appropriate place

Please review my patch. Thank you :)

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 8942728 [details] [diff] [review]
I removed the unnecessary lines of code and changed the color field from #00000 to  -moz-fieldText in the appropriate place

Looks good, thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/732a0fe9f2fb
Remove fallback border and background from the synced tabs sidebar's search field. r=dao

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/732a0fe9f2fb