Remove fallback border and background from the synced tabs sidebar's search field

RESOLVED FIXED in Firefox 59

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dao, Assigned: architjugran, Mentored)

Tracking

({good-first-bug})

Trunk
Firefox 59
All
macOS
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

(Whiteboard: [lang=css])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

a year ago
As far as I can tell these are pointless, because -moz-appearance: searchfield suppresses any CSS border and background:

https://searchfox.org/mozilla-central/rev/652fbd6270de0d3ec424d2b88f8375ff546f949f/browser/themes/osx/syncedtabs/sidebar.css#109-119,133-139

Also, 'color' should be set to -moz-fieldText rather than #000.
(Assignee)

Comment 1

a year ago
Hey,could i be assigned this bug?  i am new to open source. I think i got a decent idea what to do in this bug, i need to delete lines from 109 to 119 . and replace #000 with   -moz-fieldText in lines 134 to 137
Flags: needinfo?(dao+bmo)
(Reporter)

Comment 3

a year ago
Comment on attachment 8940472 [details] [diff] [review]
I removed the unnecessary lines of code and changed the color field from #00000 to  -moz-fieldText in the appropriate places

Hi! This is a good start, but needs a few adjustments. See below.

>--- a/browser/themes/osx/syncedtabs/sidebar.css
>+++ b/browser/themes/osx/syncedtabs/sidebar.css
>@@ -106,17 +106,6 @@
>   font-size: 12px;
>   cursor: text;
>   margin: 4px;
>-  border-width: 3px;
>-  border-style: solid;
>-  border-color: currentcolor;
>-  border-image: none;
>-  -moz-border-top-colors: transparent #888 #000;
>-  -moz-border-right-colors: transparent #FFF #000;
>-  -moz-border-bottom-colors: transparent #FFF #000;
>-  -moz-border-left-colors: transparent #888 #000;
>-  border-top-right-radius: 2px;
>-  border-bottom-left-radius: 2px;
>-  background-color: #FFF;
>   color: #000;

Need to use 'color: -moz-fieldText;' here.

> .search-box[focused="true"] {
>-  -moz-border-top-colors: -moz-mac-focusring -moz-mac-focusring #000000;
>-  -moz-border-right-colors: -moz-mac-focusring -moz-mac-focusring #000000;
>-  -moz-border-bottom-colors: -moz-mac-focusring -moz-mac-focusring #000000;
>-  -moz-border-left-colors: -moz-mac-focusring -moz-mac-focusring #000000;
>+  -moz-border-top-colors: -moz-mac-focusring -moz-mac-focusring -moz-fieldText;
>+  -moz-border-right-colors: -moz-mac-focusring -moz-mac-focusring -moz-fieldText;
>+  -moz-border-bottom-colors: -moz-mac-focusring -moz-mac-focusring -moz-fieldText;
>+  -moz-border-left-colors: -moz-mac-focusring -moz-mac-focusring -moz-fieldText;
> }

And this rule can completely go away.
Flags: needinfo?(dao+bmo)
Attachment #8940472 - Flags: review?(dao+bmo)
(Reporter)

Updated

a year ago
Assignee: nobody → architjugran
(Assignee)

Comment 4

a year ago
I could not understand what you mean by "this rule can completely go away"
Flags: needinfo?(dao+bmo)
(Reporter)

Comment 5

a year ago
(In reply to Archit Jugran from comment #4)
> I could not understand what you mean by "this rule can completely go away"

You should remove the whole .search-box[focused="true"] rule.
Flags: needinfo?(dao+bmo)
(Reporter)

Comment 6

a year ago
Still unclear what I meant?
Flags: needinfo?(architjugran)
(Assignee)

Comment 7

a year ago
Thank you Dao...it is perfectly clear.. i will upload patch in a few hours..was very busy during the previous week. Thank you
Flags: needinfo?(architjugran)
(Assignee)

Comment 8

a year ago
Please review my patch. Thank you :)
Flags: needinfo?(dao+bmo)
Attachment #8942728 - Flags: review?(dao+bmo)
(Reporter)

Comment 9

a year ago
Comment on attachment 8942728 [details] [diff] [review]
I removed the unnecessary lines of code and changed the color field from #00000 to  -moz-fieldText in the appropriate place

Looks good, thanks!
Flags: needinfo?(dao+bmo)
Attachment #8942728 - Flags: review?(dao+bmo) → review+
(Reporter)

Updated

a year ago
Attachment #8940472 - Attachment is obsolete: true

Comment 10

a year ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/732a0fe9f2fb
Remove fallback border and background from the synced tabs sidebar's search field. r=dao

Comment 11

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/732a0fe9f2fb
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.