Closed Bug 1428338 Opened 2 years ago Closed 2 years ago

Stop resetting -moz-border-*-colors in addons.css

Categories

(DevTools :: WebIDE, defect)

defect
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: dao, Assigned: abhinav.koppula, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1428325 +++

Setting -moz-border-*-colors to none shouldn't be needed since button elements don't have -moz-border-*-colors set by default:

https://searchfox.org/mozilla-central/rev/652fbd6270de0d3ec424d2b88f8375ff546f949f/devtools/client/webide/themes/addons.css#20-23
Attachment #8940220 - Flags: review?(dao+bmo)
Hi Dao,
I have created a review request for this issue.
Does this fix the issue?
Comment on attachment 8940220 [details]
Bug 1428338 - Stop resetting -moz-border-*-colors in addons.css;

https://reviewboard.mozilla.org/r/210526/#review216166

Looks good!
Attachment #8940220 - Flags: review?(dao+bmo) → review+
Keywords: checkin-needed
Assignee: nobody → abhinav.koppula
Could you please update the commit message to say r=dao rather than r=:dao? Thanks!
Keywords: checkin-needed
Done.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f4ec019eea6
Stop resetting -moz-border-*-colors in addons.css; r=dao
https://hg.mozilla.org/mozilla-central/rev/1f4ec019eea6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.