Closed
Bug 1428338
Opened 6 years ago
Closed 6 years ago
Stop resetting -moz-border-*-colors in addons.css
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: dao, Assigned: abhinav.koppula, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=css])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1428325 +++ Setting -moz-border-*-colors to none shouldn't be needed since button elements don't have -moz-border-*-colors set by default: https://searchfox.org/mozilla-central/rev/652fbd6270de0d3ec424d2b88f8375ff546f949f/devtools/client/webide/themes/addons.css#20-23
Reporter | ||
Updated•6 years ago
|
status-firefox59:
affected → ---
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8940220 -
Flags: review?(dao+bmo)
Assignee | ||
Comment 2•6 years ago
|
||
Hi Dao, I have created a review request for this issue. Does this fix the issue?
Reporter | ||
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8940220 [details] Bug 1428338 - Stop resetting -moz-border-*-colors in addons.css; https://reviewboard.mozilla.org/r/210526/#review216166 Looks good!
Attachment #8940220 -
Flags: review?(dao+bmo) → review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → abhinav.koppula
Reporter | ||
Comment 4•6 years ago
|
||
Could you please update the commit message to say r=dao rather than r=:dao? Thanks!
Keywords: checkin-needed
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•6 years ago
|
||
Done.
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f4ec019eea6 Stop resetting -moz-border-*-colors in addons.css; r=dao
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1f4ec019eea6
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•4 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•