Closed Bug 1428341 Opened 6 years ago Closed 6 years ago

Massive Xpcshell and Mozmill test failure on 2018-01-05: 11 failing Xpcshell tests, 61 failing Mozmill test (Friday bustage)

Tracking

(Not tracked)

Status:

RESOLVED FIXED

Milestone:

Thunderbird 59.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

Details

Attachments

(1 file)

1428341-datetime.patch 6 years ago Jorg K (CEST = GMT+2) 24.75 KB, patch	aceman : review+	Details \| Diff \| Splinter Review

Jorg K (CEST = GMT+2)

Assignee

Description

•

6 years ago

TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_alarm.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_datetimeformatter.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_ltninvitationutils.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell-libical.ini:calendar/test/unit/test_alarm.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell-libical.ini:calendar/test/unit/test_datetimeformatter.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell-libical.ini:calendar/test/unit/test_gdata_provider.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | chat/components/src/test/test_logger.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell-libical.ini:calendar/test/unit/test_ltninvitationutils.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unifiedcomplete/test_visit_url.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unifiedcomplete/test_tab_matches.js | xpcshell return code: 0

TEST-UNEXPECTED-TIMEOUT | toolkit/components/places/tests/unifiedcomplete/test_search_suggestions.js | Test timed out
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\cal-recurrence\testAnnualRecurrence.js | testAnnualRecurrence.js::testAnnualRecurrence
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\cal-recurrence\testBiweeklyRecurrence.js | testBiweeklyRecurrence.js::testBiweeklyRecurrence
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\cal-recurrence\testDailyRecurrence.js | testDailyRecurrence.js::testDailyRecurrence
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\cal-recurrence\testLastDayOfMonthRecurrence.js | testLastDayOfMonthRecurrence.js::testLastDayOfMonthRecurrence
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\cal-recurrence\testWeeklyNRecurrence.js | testWeeklyNRecurrence.js::testWeeklyNRecurrence
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\cal-recurrence\testWeeklyUntilRecurrence.js | testWeeklyUntilRecurrence.js::testWeeklyUntilRecurrence
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\cal-recurrence\testWeeklyWithExceptionRecurrence.js | testWeeklyWithExceptionRecurrence.js::testWeeklyWithExceptionRecurrence
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-forward-headers.js | test-forward-headers.js::test_forward_as_attachments
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\content-tabs\test-plugin-crashing.js | test-plugin-crashing.js::test_can_crash_plugin
PROCESS-CRASH | content-tabs | application crashed [@ nptest.dll + 0x23dc]
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-archive-messages.js | test-archive-messages.js::test_batch_archiver
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-deletion-with-multiple-displays.js | test-deletion-with-multiple-displays.js::test_delete_multiple_messages_with_first_selected_message_open
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-deletion-with-multiple-displays.js | test-deletion-with-multiple-displays.js::test_delete_multiple_messages_with_nth_selected_message_open
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-deletion-with-multiple-displays.js | test-deletion-with-multiple-displays.js::test_delete_multiple_messages_with_last_selected_message_open
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-deletion-with-multiple-displays.js | test-deletion-with-multiple-displays.js::test_delete_multiple_messages_including_the_last_one_with_first_open
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-deletion-with-multiple-displays.js | test-deletion-with-multiple-displays.js::test_delete_multiple_messages_including_the_last_one_with_nth_open
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-deletion-with-multiple-displays.js | test-deletion-with-multiple-displays.js::test_delete_multiple_messages_including_the_last_one_with_last_open
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-message-commands.js | test-message-commands.js::test_mark_n_read
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-message-commands.js | test-message-commands.js::test_mark_n_unread
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-message-commands.js | test-message-commands.js::test_mark_n_read_mixed
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-message-commands.js | test-message-commands.js::test_mark_n_unread_mixed
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-message-commands.js | test-message-commands.js::test_toggle_mixed
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-message-commands.js | test-message-commands.js::test_mark_menu_mixed
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-message-commands.js | test-message-commands.js::test_thread_delete_prompt
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-message-commands.js | test-message-commands.js::test_yearly_archive
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-message-commands.js | test-message-commands.js::test_monthly_archive
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-message-commands.js | test-message-commands.js::test_folder_structure_archiving
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-message-commands.js | test-message-commands.js::test_selection_after_archive
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-message-commands.js | test-message-commands.js::test_disabled_archive
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-opening-messages.js | test-opening-messages.js::test_open_multiple_messages_in_tabs
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-pane-focus.js | test-pane-focus.js::test_n_messages_selected
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-pane-focus.js | test-pane-focus.js::test_between_tab_and_multi_message
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-right-click-middle-click-messages.js | test-right-click-middle-click-messages.js::test_right_click_with_many_things_selected
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-right-click-middle-click-messages.js | test-right-click-middle-click-messages.js::test_right_click_on_existing_multi_selection
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-right-click-middle-click-messages.js | test-right-click-middle-click-messages.js::test_right_click_deletion_many_other_things_selected
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-right-click-middle-click-messages.js | test-right-click-middle-click-messages.js::test_middle_click_with_many_things_selected_background
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-right-click-middle-click-messages.js | test-right-click-middle-click-messages.js::test_middle_click_with_many_things_selected_foreground
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-right-click-middle-click-messages.js | test-right-click-middle-click-messages.js::test_middle_click_on_existing_multi_selection_background
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-right-click-middle-click-messages.js | test-right-click-middle-click-messages.js::test_middle_click_on_existing_multi_selection_foreground
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-selection.js | test-selection.js::test_selection_extension
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-selection.js | test-selection.js::test_selection_persists_through_folder_tab_changes
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-summarization.js | test-summarization.js::test_basic_summarization
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-summarization.js | test-summarization.js::test_folder_tabs_update_correctly
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-summarization.js | test-summarization.js::test_message_tabs_update_correctly
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-summarization.js | test-summarization.js::test_selection_stabilization_logic
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-summarization.js | test-summarization.js::test_summarization_thread_detection
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-summarization.js | test-summarization.js::test_summary_updates_when_new_message_added_to_collapsed_thread
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-summarization.js | test-summarization.js::test_summary_when_multiple_identities
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-summarization.js | test-summarization.js::test_display_name_no_abook
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-summarization.js | test-summarization.js::test_display_name_abook
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-summarization.js | test-summarization.js::test_display_name_abook_no_pdn
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-tabs-simple.js | test-tabs-simple.js::test_switch_to_tab_folder_b
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\folder-display\test-tooltip-multimessage.js | test-tooltip-multimessage.js::test_tooltips
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\invitations\test-imip-bar-eml.js | test-imip-bar-eml.js::test_event_from_eml
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\junk-commands\test-junk-commands.js | test-junk-commands.js::test_delete_junk_messages
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\subscribe\test-subscribe-news-filter.js | test-subscribe-news-filter.js::test_subscribe_newsgroup_filter
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\tabmail\test-tabmail-closing.js | test-tabmail-closing.js::test_opening_thread_in_tabs_closing_behaviour
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\testBasicFunctionality.js | testBasicFunctionality.js::testSmokeTest
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\testLocalICS.js | testLocalICS.js::testLocalICS
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\testTodayPane.js | testTodayPane.js::testTodayPane
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

Note that test-subscribe-news-filter.js fails due to bug 1425962, all the other ones are new failures.

M-C last good: 3acb14b949150529ec761f845f9a3d61ee
M-C first bad: 81362f7306fe413b19fdba27cd0e9a5525

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3acb14b949150529ec761f845f9a3d61ee&tochange=81362f7306fe413b19fdba27cd0e9a5525

Running
mozilla/mach xpcshell-test calendar/test/unit/test_datetimeformatter.js
locally I see:
[JavaScript Error: "TypeError: Services.intl.createDateTimeFormat is not a function" {file: "resource://calendar/modules/calUtils.jsm -> file:///c:/mozilla-source/comm-central/obj-i686-pc-mingw32/dist/bin/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calDateTimeFormatter.js" line: 79}]

Well, Services.intl.createDateTimeFormat() not being a function would of course cause huge strife.

And here we have the culprit: Bug 1428172:
https://hg.mozilla.org/mozilla-central/rev/94788650b26b#l1.12
-          let formatter = Services.intl.createDateTimeFormat(undefined, {
+          let formatter = new Services.intl.DateTimeFormat(undefined, {

:-(

Jorg K (CEST = GMT+2)

Assignee

Comment 1

•

6 years ago

Attached patch 1428341-datetime.patch — Details — Splinter Review

This fixes all 34 occurrences in 19 files.

Assignee: nobody → jorgk

Status: NEW → ASSIGNED

Attachment #8940204 - Flags: review?(acelists)

Pulsebot

Comment 2

•

6 years ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/007155df7eb9
Port bug 1428172 to C-C: s/Services.intl.createDateTimeFormat/new Services.intl.DateTimeFormat/. rs=bustage-fix

Status: ASSIGNED → RESOLVED

Closed: 6 years ago

Resolution: --- → FIXED

Jorg K (CEST = GMT+2)

Assignee

Updated

•

6 years ago

Target Milestone: --- → Thunderbird 59.0

:aceman

Comment 3

•

6 years ago

Comment on attachment 8940204 [details] [diff] [review]
1428341-datetime.patch

Review of attachment 8940204 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Attachment #8940204 - Flags: review?(acelists) → review+

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Quick Search

Massive Xpcshell and Mozmill test failure on 2018-01-05: 11 failing Xpcshell tests, 61 failing Mozmill test (Friday bustage)

Categories

(Thunderbird :: General, defect)

Tracking

(Not tracked)

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

Details

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Comment 1

Comment 2

Updated

Comment 3

Attachment

General

Description

File Name

Content Type