1428356 - Top Sites are wrongly reordered while a Top Site is dismissed, if empty Top Sites exist between them

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: Top Sites are reordered for a second after dismissing one.gif

[Affected versions]:
- Firefox 59.0a1 Build ID 20180104220114

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Have a clean new profile.
- Top Sites are ordered in such a way that the first position is empty, empty spaces exist between Top Sites and there is one Top Site in the last position.

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites and open a new tab.
2. Dismiss the 2nd Top Site and observe the behavior.
 
[Expected results]:
- The Top Site is dismissed.

[Actual results]:
- All Top Sites are reordered so that no spaces exist between them, then moved back to their original positions and the Top Site is dismissed.

[Notes]:
- Attached a screen recording of the issue.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3925

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/71a141c5c40893501b95a7c203d0ed3f70b6f1a2
Fix Bug 1428356 - dismissing/deleting Top Sites when some are pinned

https://github.com/mozilla/activity-stream/commit/406b094ead23fb132578e78820a08d4231282186
Merge pull request #3925 from rlr/bug1428356/dismiss-and-pinned

Fix Bug 1428356 - dismissing/deleting Top Sites when some are pinned

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/aaf6de934ea6

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Firefox: 60.0a1, Build ID 20180126035135

I have verified that this issue is no longer reproducible on Windows 10 x64, Ubuntu 14.04 x64 and Mac 10.12 with the latest Nightly build (60.0a1) installed. Now the "Top Sites" are not reordered while a Top Site is dismissed.

Comment 5

[Cornel Ionce [:noni] [Hubs QA]]

Updating the bug status and the tracking flags to reflect the current situation, based on the above comment.

Comment 6

[Mihai Boldan, Desktop QA [:mboldan]]

I've also managed to reproduce this issue on Firefox 59.0a1 (2018-01-05), under Windows 10x64.
The issue is no longer reproducible on Firefox 59.0b5. Tests were performed under Windows 10x64, Ubuntu 16.04x64 and under macOS 10.12.6.