Closed Bug 1428425 Opened 2 years ago Closed 2 years ago
_permissions _dialog .js | 0 == 1 - JS frame :: chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser _permissions _dialog .js :: add Permission :: line 54
59 bytes, text/x-review-board-request
Prathiksha, this is a TV (perma-)failure, that means it occurs when the test is run multiple times. In my original review of bug 1368744 I noticed but unfortunately forgot to mention that the test doesn't clean up its permission values (they remain at ALLOW). I think that could be the issue here. Can you look into fixing this? You should be able to reproduce the failure by running the test with the --verify command line option. Thank you!
Priority: P5 → P1
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Comment on attachment 8940418 [details] Bug 1428425 - Clean up browser_permissions_dialog.js. https://reviewboard.mozilla.org/r/210696/#review216434 Thanks! In the future you could use clearUserPref instead (https://searchfox.org/mozilla-central/rev/0a895028f74cffa67561150d10700abca8a931d8/modules/libpref/nsIPrefBranch.idl#236), but this works as well in this case.
Attachment #8940418 - Flags: review?(jhofmann) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/27841347525c Clean up browser_permissions_dialog.js. r=johannh
You need to log in before you can comment on or make changes to this bug.