1428425 - Intermittent browser/components/preferences/in-content/tests/browser_permissions_dialog.js | 0 == 1 - JS frame :: chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_permissions_dialog.js :: addPermission :: line 54

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: aiakab [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=154410916&repo=autoland

https://queue.taskcluster.net/v1/task/KCzkIRMDT--zlHpoSBNEdQ/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Intermittent Failures Robot]

28 failures in 119 pushes (0.235 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* mozilla-central: 16
* autoland: 12

Platform breakdown:
* linux64: 8
* windows7-32: 6
* windows10-64: 6
* osx-10-10: 4
* windows7-32-nightly: 1
* windows10-64-nightly: 1
* macosx64-nightly: 1
* linux64-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1428425&startday=2018-01-05&endday=2018-01-05&tree=all

Comment 2

[Johann Hofmann [:johannh]]

Prathiksha, this is a TV (perma-)failure, that means it occurs when the test is run multiple times. In my original review of bug 1368744 I noticed but unfortunately forgot to mention that the test doesn't clean up its permission values (they remain at ALLOW). I think that could be the issue here.

Can you look into fixing this? You should be able to reproduce the failure by running the test with the --verify command line option.

Thank you!

Comment 3

[:prathiksha]

Attachment: Bug 1428425 - Clean up browser_permissions_dialog.js.

Review commit: https://reviewboard.mozilla.org/r/210696/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210696/

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8940418 [details]
Bug 1428425 - Clean up browser_permissions_dialog.js.

https://reviewboard.mozilla.org/r/210696/#review216434

Thanks! In the future you could use clearUserPref instead (https://searchfox.org/mozilla-central/rev/0a895028f74cffa67561150d10700abca8a931d8/modules/libpref/nsIPrefBranch.idl#236), but this works as well in this case.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27841347525c
Clean up browser_permissions_dialog.js. r=johannh

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/27841347525c

Comment 7

[Intermittent Failures Robot]

37 failures in 462 pushes (0.08 failures/push) were associated with this bug in the last 7 days. 

This is the #20 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-central: 14
* autoland: 12
* mozilla-inbound: 11

Platform breakdown:
* linux64: 13
* windows7-32: 8
* windows10-64: 8
* osx-10-10: 5
* windows7-32-nightly: 1
* macosx64-nightly: 1
* linux64-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1428425&startday=2018-01-01&endday=2018-01-07&tree=all