Closed Bug 1428433 Opened 6 years ago Closed 5 years ago

Reduce accessibility tree noise by hiding shared component container elements from accessibility.

Categories

(DevTools :: Accessibility Tools, enhancement)

Product:
DevTools
Component:
Accessibility Tools
Version:
57 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: yzen, Assigned: yzen)

References

Details

Attachments

(1 file)

1428433 patch
2.33 KB, patch
Honza
: review+
Details | Diff | Splinter Review 
There are a number of shared react components that currently expose container nodes as generic "section" accessibles in: Draggable.js, SplitBox.js, TreeHeader.js. We need to add role presentation wherever possible to flatten the accessibility tree a little bit.
Attached patch 1428433 patch — — Splinter Review 

        Attachment #8951256 -
        Flags: review?(odvarko)

    
    

    
  
Comment on attachment 8951256 [details] [diff] [review]
1428433 patch

Review of attachment 8951256 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable, thanks!
Honza

        Attachment #8951256 -
        Flags: review?(odvarko) → review+
Component: Developer Tools: Shared Components → Developer Tools: Accessibility Tools

    
    

    
  
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d1e97e0569c
added role 'presentation' to shared component elements that do not have any semantics. r=Honza

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/8d1e97e0569c
Status: NEW → RESOLVED
Closed: 5 years ago

          status-firefox60:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60

    
  
Product: Firefox → DevTools
Assignee: nobody → yzenevich

          You need to log in
          before you can comment on or make changes to this bug.