1428443 - Allow panels to override picker functionality when they are active.

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P2)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Use case:

Inspector panel highlights/picks accessible objects and not DOM nodes. They do not have a box model and might have different bounds from DOM nodes. Picker in this case would need to work with objects other than DOM nodes.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1428443 patch

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8947824 [details] [diff] [review]
1428443 patch

Review of attachment 8947824 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/framework/toolbox.js
@@ +1423,5 @@
> +
> +    if (currentPanel && currentPanel.updatePickerButton) {
> +      currentPanel.updatePickerButton();
> +    } else {
> +      button.description = L10N.getStr("pickButton.tooltip");

Please insert a comment before this line that says something like "if the current panel doesn't define a custom updatePickerButton, revert the button to its default state".

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0ac728caeaa
allow panels to override picker functionality when they are active. r=pbro

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e0ac728caeaa