Whitelist custom protocol handlers for work on decentralization technologies with WebExtensions

RESOLVED FIXED in Firefox 59

Status

enhancement
RESOLVED FIXED
a year ago
5 months ago

People

(Reporter: andre, Assigned: andre)

Tracking

(Blocks 1 bug, {dev-doc-complete})

unspecified
mozilla59
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

a year ago
Decentralization is one of the priorities for a healthier internet. I'd like some protocols related to decentralization be whitelisted so that we're able to work with them from WebExtensions. The ones I'd like to have whitelisted are:

"ssb" for Secure Scuttlebutt communications
"dat" for DATproject
"ipfs", "ipns", "dweb" for IPFS

Those protocols serve no use inside Firefox or the OS that Firefox is running, they pose no risk of shadowing some other tool or hijacking anything. Currently all the decentralization projects are using forks of Electron to support those custom protocols, it would be good if we could whitelist them on Firefox and thus (maybe) be able to be the first major browser with support for those advanced protocols.

I would be happy to work on it and provide a patch to whitelist them.
Assignee

Comment 1

a year ago
This patch adds "dat", "dweb", "ipfs", "ipns" and "ssb" to the whitelist of custom protocols to be used by WebExtensions. All of them are used by decentralization technologies.
Assignee: nobody → andre
Comment on attachment 8940368 [details] [diff] [review]
Patch that whitelists ssb, dat and ipfs protocols for webextensions

lgtm
Attachment #8940368 - Flags: review+

Comment 3

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2cb8a06bcf1
Add DAT, IPFS, and SSB to the webextension protocol whitelist. r=mixedpuppy
Keywords: checkin-needed

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c2cb8a06bcf1
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59

Comment 5

a year ago
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(andre)
Assignee

Comment 6

a year ago
I don't think manual testing is required. This was only an addition to the items in a whitelist which already has been tested. I have set "qe-verify" to "+" to reflect that. I can still provide an add-on if someone feel it is really needed. 

also thanks a lot to Shane and Eliza for pushing this forward with the proper methods. I am new to this.
Flags: needinfo?(andre) → qe-verify+

Updated

a year ago
Flags: qe-verify+ → qe-verify-

Comment 7

a year ago
I have set the "qe-verify" to "-" to reflect that no further manual QA testing is required.
Assignee

Comment 8

a year ago
Oops, got the flags mixed, thought the + was the one that flagged that it required no manual testing. Sorry for the mistake.

Comment 9

a year ago
FYSA, apart from this change to Firefox, WebExtensions will not pass linting or be accepted to AMO unless addons-linter is updated as well. See issue at https://github.com/mozilla/addons-linter/issues/1783
Blocks: p2p
Updated https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/protocol_handlers. Marking as dev-doc-complete, but please let me know if we need anything else.

Updated

11 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.