Closed Bug 1428455 Opened 2 years ago Closed 2 years ago

Update Debugger Frontend (5)

Categories

(DevTools :: Debugger, defect)

defect
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file, 1 obsolete file)

Assignee: nobody → jlaster
Attached patch 5-1.patch (obsolete) — Splinter Review
Attachment #8940338 - Flags: review?(jdescottes)
Comment on attachment 8940338 [details] [diff] [review]
5-1.patch

Review of attachment 8940338 [details] [diff] [review]:
-----------------------------------------------------------------

Can we use something that looks like semantic versioning? e.g. v0.5.0 or something like that.
That's a well known convention. Each number has a role which is good to have for communicating about a release. 
I can see this being helpful to ease risk assessment of major release vs build release for instance.

Please update the commit message. Ideally the version number should also be in the README.

Did not see major regressions, only a bug linked to https://github.com/devtools-html/debugger.html/commit/17e744331644cacd0e40815b175e9eb478d32ed1, will log later.

::: devtools/client/debugger/new/README.mozilla
@@ +1,4 @@
>  This is the debugger.html project output.
>  See https://github.com/devtools-html/debugger.html
>  
> +Taken from upstream commit: 09ddaa8cd83ee96dee343dc408295f427b8e7036

Should mention the version number. 

Commit not found on GitHub?

::: devtools/client/locales/en-US/debugger.properties
@@ +356,5 @@
>  # LOCALIZATION NOTE (editor.searchResults): Editor Search bar message
>  # for the summarizing the selected search result. e.g. 5 of 10 results.
>  editor.searchResults=%d of %d results
>  
> +# LOCALIZATION NOTE (sourceSearch.singleResult): Copy shown when there is one result.

I recently fixed a bunch of bad localization notes on our properties files. We shouldn't override this change and this needs to be synchronized back before releasing.
Attachment #8940338 - Flags: review?(jdescottes) → review-
1. Versioning - I like the idea. I don't know if we need to differentiate between minor and major, but v5.0 and v5.1 makes sense... vY.X where Y is a new version and X is a bug fix.

2. Version in the Readme. Good idea.

3. Checking for changes... Nice catch. I'm skipping the ship2gecko scripts right now as I'm trying to re-think some steps. I'll make sure to double check these files before making new versions.
Attached patch 5-2.patchSplinter Review
Attachment #8940338 - Attachment is obsolete: true
Attachment #8940542 - Flags: review?(jdescottes)
Comment on attachment 8940542 [details] [diff] [review]
5-2.patch

Review of attachment 8940542 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: devtools/client/debugger/new/README.mozilla
@@ +1,5 @@
>  This is the debugger.html project output.
>  See https://github.com/devtools-html/debugger.html
>  
> +Version 5.0
> +Comparison - https://github.com/devtools-html/debugger.html/compare/release...release-5

Is the release branch the same as release-4 ?
Attachment #8940542 - Flags: review?(jdescottes) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d1773460b9d
Update Debugger Frontend v5.0. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/7d1773460b9d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.