1428494 - Fix installation of mozmill for local development

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Tom Prince [:tomprince]]

Currently, it creates it's own virtualenv, with hand written code. Instead, it should leverage the existing build virtualenv.

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/65634ac5e471
Stop installing mozmill in automation; rs=bustage-fix

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b72aa771a12d
(typo-fix) Stop installing mozmill in automation; rs=bustage-fix

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/comm-central/rev/27191bf09df8
Backed out changeset b72aa771a12d, 65634ac5e471 for breaking mozmill tests on taskcluster. CLOSED TREE

Comment 4

[Tom Prince [:tomprince]]

Attachment: Bug 1428494: Package mozmill test resources in mozbuild;

Review commit: https://reviewboard.mozilla.org/r/210790/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210790/

Comment 5

[Tom Prince [:tomprince]]

Attachment: Bug 1428494: Stop installing mozmill in automation;

Review commit: https://reviewboard.mozilla.org/r/210792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210792/

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8940582 [details]
Bug 1428494: Package mozmill test resources in mozbuild;

https://reviewboard.mozilla.org/r/210790/#review216670

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8940583 [details]
Bug 1428494: Stop installing mozmill in automation;

https://reviewboard.mozilla.org/r/210792/#review216672

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3235e39f2924
Package mozmill test resources in mozbuild; r?Fallen
https://hg.mozilla.org/comm-central/rev/c470737be118
Stop installing mozmill in automation; r?Fallen

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bc092a4b0df8
Fix installation of mozmill virtualenv in automation; rs=bustage-fix

Comment 10

[Phabricator Automation]

Comment on attachment 8942782 [details]
Bug 1428494: Clean up linting of installmozmill.py; r?Fallen

Philipp Kewisch [:Fallen]  has approved the revision.

https://phabricator.services.mozilla.com/D393#9463

Comment 11

[Phabricator Automation]

Comment on attachment 8942783 [details]
Bug 1428494: Install mozterm when installing mozmill; r?Fallen

Philipp Kewisch [:Fallen]  has approved the revision.

https://phabricator.services.mozilla.com/D394#9465

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4f8929c9473c
Clean up linting of installmozmill.py; r=Fallen
https://hg.mozilla.org/comm-central/rev/6da9066ad17a
Install mozterm when installing mozmill; r=Fallen

Comment 13

[Joachim Herb]

Why is mozterm taken from the topsrcdir/python? It is also in the directory tools which is included in the redestributed zip archive of the tests, e.g. thunderbird-60.0a1.en-US.win32.common.tests.zip

(or is this the same directory?)

Comment 14

[Tom Prince [:tomprince]]

The path $topsrcdir/python is correct when working out of a source checkout, but not from the tests bundle. Those are primarily meant for consumption by our build and test automation; I was unaware that there were instructions for using them for testing addons.

Comment 15

[Joachim Herb]

It is easy to work around this with links/junctions. So only the documentation at https://developer.mozilla.org/en-US/docs/Mozilla/Thunderbird/Thunderbird_MozMill_Testing/Running_Thunderbird_MozMill_tests_from_packaged_tests has to be updated.

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:tomprince, maybe it's time to close this bug?

Comment 17

[Geoff Lankow (:darktrojan)]

I've opened bug 1516843 to take over from here, so I'm closing this one.