1428508 - Remove the ThLog Angular service

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P3)

Description

[Cameron Dawson [:camd]]

I created this ages ago as a way to help do more specific logging.  But you need to either whitelist or blacklist components to see logging from them and, to be honest, I'm not sure it's providing any value above adding your own console.log statements while debugging.

I suspect this is just adding bloat.  I could be wrong though.  :) Opinions?

Comment 1

[Ed Morley [:emorley]]

Thank you for filing! Yeah I'm not sure I've ever made use of ThLog at all. After bug 1428051 the number of grep hits for 'ThLog' are certainly a lot lower. It's also possible there are existing React logging frameworks we could use should we ever need something more advanced again in the future.

Comment 2

[William Lachance (:wlach)]

I have never used ThLog so don't have a strong opinion on it. :)

Comment 3

[Ed Morley [:emorley]]

I don't know what the best option is for replacement. Perhaps one of:
* using console.{log,error,...} directly (and disabling the AirBnB rule that forbids it)
* using https://www.npmjs.com/package/debug (TIL it supports browser usages too)
* <something else>

I think whatever we use, we should:
* keep production logging to a minimum (using New Relic JS monitoring or something like Rollbar/Sentry/Raygun for JS exception tracking seems more appropriate)
* not require a local config file (eg the NPM `debug` package supports controlling logging filters using localstorage)

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3251

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 8952888 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3251

Yey more code removal! :-D

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/c422eb968dd9c21af8fd01c4ad657fa4a1967784
Bug 1428508 - Remove the ThLog Angular service (#3251)