Closed Bug 1428530 Opened 3 years ago Closed 3 years ago
Separate out mozilla::intl::Locale
LocaleService::Locale class is something I'd like to see used by all code that has to parse locale codes (bug 1349377). As the first step, I'd like to separate it out of LocaleService, and then consider adding a public interface (mozILocale) and hopefully then further aligning it with BCP47 (support for unicode extensions etc.).
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8940409 [details] Bug 1428530 - Separate out mozilla::intl::Locale. https://reviewboard.mozilla.org/r/210684/#review220454 ::: intl/locale/LocaleService.cpp:14 (Diff revision 2) > #include "mozilla/ClearOnShutdown.h" > #include "mozilla/Omnijar.h" > #include "mozilla/Preferences.h" > #include "mozilla/Services.h" > #include "mozilla/intl/OSPreferences.h" > +#include "mozilla/intl/Locale.h" Put Locale before OSPreferences (alphabetical). We're not very consistent about this in many places, but let's be tidy in this case at least!
Attachment #8940409 - Flags: review?(jfkthame) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/994e33a96d17 Separate out mozilla::intl::Locale. r=jfkthame
Backed out for build bustage at z:\build\build\src\intl\locale\locale.h on a CLOSED TREE Push that caused the bustages: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=994e33a96d173ce59f6f8a57056801d333dea9d6 Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=158022595&repo=autoland&lineNumber=10125 Backout: https://hg.mozilla.org/integration/autoland/rev/f84c3854510ee367372477abbd331a9c74bc0ea1
Jonathan - do you have any idea what's going on? I asked on #developers and nobody had any clue :(
Flags: needinfo?(gandalf) → needinfo?(jfkthame)
The hypothesis Jonathan came up with is that due to case-insensitive Windows file system some *other* code tries to include `locale.h` and ends up including our Locale.h. We'll try to rename it to MozLocale.*
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/641eff95e201 Separate out mozilla::intl::Locale. r=jfkthame
You need to log in before you can comment on or make changes to this bug.