Separate out mozilla::intl::Locale

RESOLVED FIXED in Firefox 60

Status

()

enhancement
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: gandalf, Assigned: gandalf)

Tracking

unspecified
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

LocaleService::Locale class is something I'd like to see used by all code that has to parse locale codes (bug 1349377).

As the first step, I'd like to separate it out of LocaleService, and then consider adding a public interface (mozILocale) and hopefully then further aligning it with BCP47 (support for unicode extensions etc.).
(Assignee)

Updated

a year ago
Blocks: 1349377
(Assignee)

Updated

a year ago
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Priority: -- → P3
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Blocks: 1428698
No longer blocks: 1349377

Comment 3

a year ago
mozreview-review
Comment on attachment 8940409 [details]
Bug 1428530 - Separate out mozilla::intl::Locale.

https://reviewboard.mozilla.org/r/210684/#review220454

::: intl/locale/LocaleService.cpp:14
(Diff revision 2)
>  #include "mozilla/ClearOnShutdown.h"
>  #include "mozilla/Omnijar.h"
>  #include "mozilla/Preferences.h"
>  #include "mozilla/Services.h"
>  #include "mozilla/intl/OSPreferences.h"
> +#include "mozilla/intl/Locale.h"

Put Locale before OSPreferences (alphabetical). We're not very consistent about this in many places, but let's be tidy in this case at least!
Attachment #8940409 - Flags: review?(jfkthame) → review+
Comment hidden (mozreview-request)

Comment 5

a year ago
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/994e33a96d17
Separate out mozilla::intl::Locale. r=jfkthame
Comment hidden (mozreview-request)
(Assignee)

Comment 8

a year ago
Jonathan - do you have any idea what's going on? I asked on #developers and nobody had any clue :(
Flags: needinfo?(gandalf) → needinfo?(jfkthame)
Comment hidden (mozreview-request)
The hypothesis Jonathan came up with is that due to case-insensitive Windows file system some *other* code tries to include `locale.h` and ends up including our Locale.h.

We'll try to rename it to MozLocale.*
Flags: needinfo?(jfkthame)

Comment 11

a year ago
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/641eff95e201
Separate out mozilla::intl::Locale. r=jfkthame
https://hg.mozilla.org/mozilla-central/rev/641eff95e201
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.