Closed Bug 1428582 Opened 2 years ago Closed 2 years ago

PATH LENGTH lint spuriously failing based on entire local path

Categories

(Testing :: web-platform-tests, defect)

Product:
Testing
Component:
web-platform-tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox59 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: gsnedders, Assigned: gsnedders)

Details

Attachments

(1 file)

Bug 1428582 - Preprocess wpt lint paths to be relative to the wpt root
59 bytes, text/x-review-board-request
jgraham
: review+
Details 
With my local branch for bug 1427114 checked out:

$ ./mach lint -l wpt -w staged
  None  error  //mnt/home-extra/gsnedders/Documents/other-projects/mozilla/gecko/testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/text3/text-align-match-parent-01.html longer than maximum path length (182 > 150)  PATH LENGTH (wpt)

We appear to be running:

/mnt/home-extra/gsnedders/Documents/other-projects/mozilla/gecko/testing/web-platform/tests/wpt lint --json /mnt/home-extra/gsnedders/Documents/other-projects/mozilla/gecko/testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/text3/text-align-match-parent-01.html

Perhaps relevantly, this seems to end up with an assertion failing about path being an absolute path (albeit in very unrelated code). Seemingly ./wpt lint assumes that the path is relative to the repo_root, and PATH LENGTH literally just does len(path).
Assignee: nobody → geoffers+mozilla
Status: NEW → ASSIGNED
(Also, on my system, my CWD is typically /home/gsnedders/Documents/other-projects/mozilla/gecko, where /home/gsnedders/Documents/other-projects is a symlink, though that appears not to be relevant here.)
Comment on attachment 8940482 [details]
Bug 1428582 - Preprocess wpt lint paths to be relative to the wpt root

https://reviewboard.mozilla.org/r/210728/#review216460
Attachment #8940482 - Flags: review?(james) → review+
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/03edb935ed68
Preprocess wpt lint paths to be relative to the wpt root r=jgraham
https://hg.mozilla.org/mozilla-central/rev/03edb935ed68
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.