PATH LENGTH lint spuriously failing based on entire local path

RESOLVED FIXED in Firefox 59

Status

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: gsnedders, Assigned: gsnedders)

Tracking

Trunk
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
With my local branch for bug 1427114 checked out:

$ ./mach lint -l wpt -w staged
  None  error  //mnt/home-extra/gsnedders/Documents/other-projects/mozilla/gecko/testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/text3/text-align-match-parent-01.html longer than maximum path length (182 > 150)  PATH LENGTH (wpt)

We appear to be running:

/mnt/home-extra/gsnedders/Documents/other-projects/mozilla/gecko/testing/web-platform/tests/wpt lint --json /mnt/home-extra/gsnedders/Documents/other-projects/mozilla/gecko/testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/text3/text-align-match-parent-01.html

Perhaps relevantly, this seems to end up with an assertion failing about path being an absolute path (albeit in very unrelated code). Seemingly ./wpt lint assumes that the path is relative to the repo_root, and PATH LENGTH literally just does len(path).
(Assignee)

Updated

a year ago
Assignee: nobody → geoffers+mozilla
Status: NEW → ASSIGNED
(Assignee)

Comment 1

a year ago
(Also, on my system, my CWD is typically /home/gsnedders/Documents/other-projects/mozilla/gecko, where /home/gsnedders/Documents/other-projects is a symlink, though that appears not to be relevant here.)
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8940482 [details]
Bug 1428582 - Preprocess wpt lint paths to be relative to the wpt root

https://reviewboard.mozilla.org/r/210728/#review216460
Attachment #8940482 - Flags: review?(james) → review+

Comment 4

a year ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/03edb935ed68
Preprocess wpt lint paths to be relative to the wpt root r=jgraham

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/03edb935ed68
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.