Closed Bug 1428605 Opened 2 years ago Closed 2 years ago

ExceptionStackOrNull and PromiseRejectionHandlingState should have a namespace

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: ptomato, Assigned: ptomato)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171112125346

Steps to reproduce:

In the SpiderMonkey API, ExceptionStackOrNull and PromiseRejectionHandlingState aren't in any namespace.



Expected results:

They should probably be in the JS:: namespace.
Attachment #8940598 - Flags: review?(sphink)
Comment on attachment 8940598 [details] [diff] [review]
Add JS:: namespace to API where it's missing

Review of attachment 8940598 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8940598 - Flags: review?(sphink) → review+
Keywords: checkin-needed
Assignee: nobody → philip.chimento
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcbf0e6ea93c
Add JS:: namespace to API where it's missing. r=sfink
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bcbf0e6ea93c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.