Closed Bug 1428658 Opened 2 years ago Closed Last year

After turning autocomplete off Enter doesn't submit the contents of the address bar, if autocomplete has already been used that session

Categories

(Firefox :: Address Bar, defect, P2)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1446551

People

(Reporter: Kwan, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

STR:
0) Type example.com into the address bar and hit enter
1) Go to about:preferences
2) Go to "Privacy & Security" (or search for "suggest")
3) Under "When using the address bar, suggest" untick everything (this results in browser.urlbar.autocomplete.enabled being false)
4) Type example.com into the address bar and hit enter

ER:
navigate to example.com

AR:
nothing

It does work if one hits an arrow button before enter however.
Why?
Because here: https://searchfox.org/mozilla-central/rev/51d4c2d9ce39faec9d74e9597b69d5cc697bd93f/browser/base/content/urlbarBindings.xml#1371
when just hitting enter, this.popup.selectedIndex always equals 0, if the address bar has already been used with autocomplete on in that browsing session, so nothing ever happens.
After hitting an arrow (or in a new session without autocomplete already used), it's -1.
Restarting the browser fixes it, so this is probably minor, but I saw a few other bugs [1] about enter not doing anything in some circumstances, so thought this worth filing as it may be the same cause as the others (no popup shown but selectedIndex 0 instead of -1), especially bug 1403217 watching the GIF.

Marco I'm needinfoing you based on bug 1403217 comment 2, just to make sure you see it.

[1] bug 1408398, bug 1427166, bug 1403217

(aaand right before submitting I've noticed bug 1418251, which this should probably be duped to)
Flags: needinfo?(mak77)
Duplicate of this bug: 1418251
Surely it's not nice, I agree it's an edge case since not many users completely disable autocomplete, but still annoying when it happens.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(mak77)
Priority: -- → P2
Whiteboard: [fxsearch]
Ian, is this still an issue? I can't seem to reproduce it, example.com always loads. There's been a few changes to the address bar recently (including bug 1446551 which may have helped this).
Flags: needinfo?(moz-ian)
mozregression --find-fix --bad 60 --pref "browser.urlbar.suggest.searches:false" -a "about:preferences#privacy" 
(Ctrl+T, type example.com, hit enter, tab back to prefs, untick all three under "Address Bar", Ctrl+L, type example.com, hit enter)
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d42b55d603032606bc40ae6b24a0aa27e6d30c72&tochange=2fefab7d7dc192cdaf66d88a90b76e763b762465

This was indeed fixed by bug 1446551, well done Drew!
Status: NEW → RESOLVED
Closed: Last year
Flags: needinfo?(moz-ian)
Resolution: --- → DUPLICATE
Duplicate of bug: 1446551
You need to log in before you can comment on or make changes to this bug.