Closed
Bug 1428682
Opened 7 years ago
Closed 7 years ago
OggDemuxer doesn't set MediaData::mOffset
Categories
(Core :: Audio/Video: Playback, defect, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
mOffset is important for MediaCache to evaluate the playback rate in bytes for a live stream. Failing to set this field (initially 0) will cause MediaCache to assume very low playback rate (in bytes) and not to download enough bytes for decoder to consume without underflow.
This issue is manifested by bug 1427527 where a live ogg stream is played.
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8940571 -
Flags: review?(jyavenard)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8940571 [details]
Bug 1428682 - set MediaData::mOffset properly in OggDemuxer.
https://reviewboard.mozilla.org/r/210768/#review216572
Attachment #8940571 -
Flags: review?(jyavenard) → review+
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8940571 [details]
Bug 1428682 - set MediaData::mOffset properly in OggDemuxer.
https://reviewboard.mozilla.org/r/210768/#review216574
::: commit-message-2aed1:1
(Diff revision 1)
> +Bug 1428682 - OggDemuxer doesn't set MediaData::mOffset.
IIUC, the commit header should be about what is done, not summarize what the problem was
Comment 4•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8940571 [details]
Bug 1428682 - set MediaData::mOffset properly in OggDemuxer.
https://reviewboard.mozilla.org/r/210768/#review216574
> IIUC, the commit header should be about what is done, not summarize what the problem was
https://wiki.mozilla.org/Bugzilla:Committing_Patches
"Note that the description given on the commit comment should describe what the patch actually does (in a broad sense), which may not necessarily match the summary of the bug being fixed. For example, of the summary of the bug is "Bugzilla doesn't do Foo", then your description in the commit comment should say something like "Make Bugzilla do Foo".
"
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1249a196a5a0
set MediaData::mOffset properly in OggDemuxer. r=jya
Comment 8•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•