1428682 - OggDemuxer doesn't set MediaData::mOffset

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

mOffset is important for MediaCache to evaluate the playback rate in bytes for a live stream. Failing to set this field (initially 0) will cause MediaCache to assume very low playback rate (in bytes) and not to download enough bytes for decoder to consume without underflow.

This issue is manifested by bug 1427527 where a live ogg stream is played.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1428682 - set MediaData::mOffset properly in OggDemuxer.

mOffset is important for MediaCache to evaluate the playback rate in bytes for
a live stream. Failing to set this field (initially 0) will cause MediaCache to
assume very low playback rate (in bytes) and not to download enough bytes for
decoder to consume without underflow.

This issue is manifested by bug 1427527 where a live ogg stream is played.

Review commit: https://reviewboard.mozilla.org/r/210768/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210768/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8940571 [details]
Bug 1428682 - set MediaData::mOffset properly in OggDemuxer.

https://reviewboard.mozilla.org/r/210768/#review216572

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8940571 [details]
Bug 1428682 - set MediaData::mOffset properly in OggDemuxer.

https://reviewboard.mozilla.org/r/210768/#review216574

::: commit-message-2aed1:1
(Diff revision 1)
> +Bug 1428682 - OggDemuxer doesn't set MediaData::mOffset.

IIUC, the commit header should be about what is done, not summarize what the problem was

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8940571 [details]
Bug 1428682 - set MediaData::mOffset properly in OggDemuxer.

https://reviewboard.mozilla.org/r/210768/#review216574

> IIUC, the commit header should be about what is done, not summarize what the problem was

https://wiki.mozilla.org/Bugzilla:Committing_Patches
"Note that the description given on the commit comment should describe what the patch actually does (in a broad sense), which may not necessarily match the summary of the bug being fixed. For example, of the summary of the bug is "Bugzilla doesn't do Foo", then your description in the commit comment should say something like "Make Bugzilla do Foo".

"

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8940571 [details]
Bug 1428682 - set MediaData::mOffset properly in OggDemuxer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210768/diff/1-2/

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1249a196a5a0
set MediaData::mOffset properly in OggDemuxer. r=jya

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1249a196a5a0