1428717 - netProviderEnhancer for MESSAGE_OPEN action throws when not on a network message

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce:
1. Go to data:text/html,Hello<script>window.setTimeout(() => { throw new Error("ooops")}, 0)</script>
2. Open the console
3. Click on the "Error: oops" expand arrow

Expected results:

The stacktrace is shown, and the arrow is rotated

Actual results:

The stacktrace isn't shown, and the arrow is not rotated. 
There is an error in the browser console : 
TypeError: message is undefined | store.js:203:13

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

The issue lays into those lines : 

https://searchfox.org/mozilla-central/rev/f42618c99dcb522fb674221acfbc68c2d92e7936/devtools/client/webconsole/new-console-output/store.js#200,203

Here, the netProvider enhancer react to a MESSAGE_OPEN action, gets the networkUpdate of the message with the action id and goes on.
The issue is that if the message opened is not a network one, there is no networkUpdate, and thus message.openedOnce will throw.
Guarding the if with message will probably fix the issue.
We should also add a test to make sure we don't regress this.

console.group message are bitten by that too (if you close a group, you can't reopen it).

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1428717 - Fix netProviderEnhancer for MESSAGE_OPEN action for non-network message;.

There was an exception thrown by the netProviderEnhancer because it
retrieves the networkMessageUpdate and access a property on it.
On non-network message, the networkMessageUpdate is undefined, and
accessing the property throws.

We fix this by simply checking if message is not falsy before accessing
the property.

A couple of tests were added to make sure we don't regress this case. This
required changing the setupStore helper a bit to pass a hud stub to the
createStore function (the net enhancer is called only if the hud has a proxy
object). This made some test fail because they weren't dispatching enough
argument to the networkMessageUpdate action.

Review commit: https://reviewboard.mozilla.org/r/211018/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211018/

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8940724 [details]
Bug 1428717 - Fix netProviderEnhancer for MESSAGE_OPEN action for non-network message;.

https://reviewboard.mozilla.org/r/211018/#review216724

Looks good, thanks for fixing it!

r+, and just one nit comment.

Honza

::: devtools/client/webconsole/new-console-output/test/store/messages.test.js:585
(Diff revision 1)
> +      dispatch(actions.messageClose(firstMessageId));
> +
> +      expanded = getAllMessagesUiById(getState());
> +      expect(expanded.length).toBe(0);
> +
> +      dispatch(actions.messageOpen(firstMessageId));

nit: do we need this last open? The exception has been opened once in this test no?

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8940724 [details]
Bug 1428717 - Fix netProviderEnhancer for MESSAGE_OPEN action for non-network message;.

https://reviewboard.mozilla.org/r/211018/#review216724

> nit: do we need this last open? The exception has been opened once in this test no?

you're right

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8940724 [details]
Bug 1428717 - Fix netProviderEnhancer for MESSAGE_OPEN action for non-network message;.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211018/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3c95327159c
Fix netProviderEnhancer for MESSAGE_OPEN action for non-network message;r=Honza.

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d3c95327159c