1428729 - On otto.de, credit card autofill doesn't work because "KKnr/KKMonth/KKYear" can't be identified as "cc-number/cc-exp-month/cc-exp-year"

Status: NEW

(Toolkit :: Form Autofill, defect, P4)

Description

[ovidiu boca[:Ovidiu]]

Affected versions]:

Tested on Nightly 59.0a1(2018-01-04)

[Affected platforms]:

Tested on Mac OS X 10.12, Windows 10

[Steps to reproduce]:

Prerequisites:
 1. use VPN to connect to a Germany server. 
 
 STR:

1. Go to https://www.otto.de and buy an item and proceed until you are in the credit-card section.
2. Double click on the "Kartennummer" field. 


[Expected result]:

The autofill credit card suggestions are displayed. 

[Actual result]:

Nothing happens. 

NOTE: Here is a video of the actual result: https://streamable.com/mi6ps

Comment 1

[Steve Chung [:steveck]]

It's heuristic issue that we can not match cc-number/cc-expiry-date fields because the returned element strings are unable to match any regexp rule(KKnr/KKMonth/KKYear). The only possible way is to get the label textContent, and it's not working currently because the "label" is actually a span with class="label" in this website.

Comment 2

[Luke Chang [:lchang] (inactive)]

Looks like "KK" stands for "Kreditkarte" ("credit card" in German) and I do lack these keywords in our rules.

However, I don't think we should include "KK" in our keyword list as it's too general to provide useful information. Besides, "KKnr" even doesn't include "Nummer" ("number" in German) in the string. I don't know for sure if "KKnr" is a common expression used for "credit card number" in German but it seems to me that the information that the website provides is not sufficient to determine what type the field is.

Since the website doesn't use <label>, either, we have no other clues to guess. Therefore, I would say this bug can't be fixed because of the insufficient information.

I'll remove the V2 flag at this moment but keep it opened to track if there's the same issue on other German websites.

Comment 3

[Lauren Fu(Firefox EPM)]

I tested this website with Chrome but without VPN. Kartennummer (credit card number) and Jahr (expired year) can be auto filled. However, Gültig bis Monat (expired month) can not be filled.

Comment 4

[Sean Lee [:seanlee][:weilonge]]

The patch in bug 1428732 fixes the similar issue with this bug, but I need to refine cc-exp parser to resolve the case of two non-adjacent cc-exp-month and cc-exp-year. My idea is to remain cc-exp-year and cc-exp-month when there is no adjacent field, and non-adjacent cc-exp will be removed like what we did in [1].

[1] https://searchfox.org/mozilla-central/rev/88439dc6c5b02e167032374071cdc697a056efa1/browser/extensions/formautofill/FormAutofillHeuristics.jsm#702-705

Comment 5

[Sean Lee [:seanlee][:weilonge]]

Just a quick note. Without the logic in [1], the heuristics will misdetect birthday fields as cc-exp-month or cc-exp-year.