1428730 - Rendering issues on Amazon and Twitter with 4k screen

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Whenever I load Amazon or Twitter either I see rendering issues immediately or when scrolling. The page is usually missing images, has black rectangles, or is painted twice from the top when scrolling down.

mozregression gave me the following:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ccd7b237c4337a00e45bf18ac2d0218c61e1134d&tochange=6b52d9870d2d16a29e3075627953304c574f11ed

This doesn't seem to be an issue on macOS, can't reproduce it there.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

I confirmed locally that backing out [1] fixes the issue for me. What's confusing is that I can't reproduce this with a clean profile, it only happens with my default profile.

[1] https://hg.mozilla.org/integration/mozilla-inbound/rev/6b52d9870d2d16a29e3075627953304c574f11ed

Comment 2

[Jamie Nicol [:jnicol]]

Not affecting OS X makes sense, because it uses tiling rather than RotatedBuffer. If you post your about:support of the affected profile I might be able to see a pref change causing it.

Comment 3

[Jamie Nicol [:jnicol]]

Also, if you could set layers.dump=true then post the terminal output on amazon or twitter that would be really helpful. Thanks!

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

about:support has no strings unfortunately. The modified prefs aren't listed. I'll try to get you a layers dump.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: layers.dump=true log

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Tim Taubert [:ttaubert] from comment #4)
> about:support has no strings unfortunately. The modified prefs aren't
> listed. I'll try to get you a layers dump.

FTR, that too is due to the rendering issue reported here in this bug.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Wait, this wasn't uplifted yet.

Comment 8

[Gerry Chang [:gchang]]

Track 58+/59+ as bug 1417310 caused this regression and bug 1417310 has already been in Beta58.

Comment 9

[Jamie Nicol [:jnicol]]

Attachment: Bug 1428730 - Allow surfaces up to a width or height of 16384.

This reverts bug 1417310, which confused the concepts of "reasonable"
and "allowed" surface size and set the max to the defined reasonable
limit of 8192. This is too low for 4k screens. We now go back to using
the correct variable ("allowed") for the maximum size, but reduce its
value from 32767 to 16384.

Review commit: https://reviewboard.mozilla.org/r/211390/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211390/

Comment 10

[Jamie Nicol [:jnicol]]

Comment on attachment 8941123 [details]
Bug 1428730 - Allow surfaces up to a width or height of 16384.

Even at a 16384 limit we break things. I think we should revert bug 1417310

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Bug 1417310 has been backed out from both branches.