Closed
Bug 1428852
Opened 6 years ago
Closed 6 years ago
Crash reporter leaks file handle
Categories
(Toolkit :: Crash Reporting, defect)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: jeanluc.bonnafoux, Assigned: jeanluc.bonnafoux)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 Build ID: 20180103231032 Steps to reproduce: Static analysis of C++ code points out UIPruneSavedDumps function leaks file handle. Actual results: dirlist handle (created through FindFirstFile call) in UIPruneSavedDumps is not closed by calling function: FindClose Expected results: The find handle should have been released with a call to FindClose
|
||
Updated•6 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
| Comment hidden (mozreview-request) |
|
|
||
Updated•6 years ago
|
Assignee: nobody → jeanluc.bonnafoux
Status: NEW → ASSIGNED
|
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8942519 [details] Bug 1428852 - Crash reporter leaks file handle https://reviewboard.mozilla.org/r/212774/#review218580 Looks good to me, thank you for your contribution!
Attachment #8942519 -
Flags: review?(gsvelto) → review+
Keywords: checkin-needed
Pushed by btara@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/75678e33c933 Crash reporter leaks file handle r=gsvelto
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/75678e33c933
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•