1428882 - Add driver code to moz-central to trigger Tripwire to run a web test.

Status: RESOLVED INACTIVE

(Web Compatibility :: Tooling & Investigations, enhancement)

Description

[Thomas Wisniewski]

Create a basic test-driver which loads the Tripwire extension and has it run a web test file (with the test results to be parsed out in a subsequent bug).

Tripwire itself may be stored in m-c along with the driver, but the web test files should be possible to fetch from a remote server configured in the driver.

Comment 1

[Thomas Wisniewski]

Attachment: Bug 1428882 - Add Tripwire as a marionette test.

Review commit: https://reviewboard.mozilla.org/r/231316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231316/

Comment 2

[Code Review Bot [:reviewbot]]

Comment on attachment 8962500 [details]
Bug 1428882 - Add Tripwire as a marionette test.

https://reviewboard.mozilla.org/r/231316/#review236782


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: toolkit/components/tripwire/tests/marionette/tripwire/content.js:171
(Diff revision 1)
> +// return the same sequence of values as the various scripts request them.
> +//
> +// Note we make these changes with an eval(), since any cross-window closures
> +// will break when the addon reloads, leaving behind a slew of mysterious
> +// "cannot access dead object" messages in the browser console.
> +window.eval(`(function() {

Error: Eval can be harmful. [eslint: no-eval]

Comment 4

[Mike Taylor [:miketaylr]]

We're not currently working on this.