1428923 - Implement setDefaultPrefAndLock functionality required to implement several policies

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, enhancement, P1)

Description

[:Felipe Gomes (needinfo for replies!)]

This functionality is required to implement several of the trivial policies. We must set a new default value to a prof and lock it so that every consumer gets that value.

One non-trivial aspect of this implementation is that when using the distribution.ini customization, a reload-default-prefs notification is sent, which might end up resetting the changes done by this function.

It's likely that a sysadmin user of the new policy engine might also be using distribution.ini, so we should ensure that this conflict is handled.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

(In reply to :Felipe Gomes (needinfo me!) from comment #0)
> One non-trivial aspect of this implementation is that when using the
> distribution.ini customization, a reload-default-prefs notification is sent,
> which might end up resetting the changes done by this function.

I've verified that a *locked* pref doesn't get reset, even with the reload-default-prefs notification. So this won't be a problem after all

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1428923 - Implement setDefaultPrefAndLock helper function needed to implement several policies.

Review commit: https://reviewboard.mozilla.org/r/212994/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212994/

Comment 3

[Mike Kaply [:mkaply]]

Comment on attachment 8942734 [details]
Bug 1428923 - Implement setDefaultPrefAndLock helper function needed to implement several policies.

https://reviewboard.mozilla.org/r/212992/#review218926

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 8942734 [details]
Bug 1428923 - Implement setDefaultPrefAndLock helper function needed to implement several policies.

https://reviewboard.mozilla.org/r/212994/#review218928

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfca1cdb9218
Implement setDefaultPrefAndLock helper function needed to implement several policies. r=mkaply

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/bfca1cdb9218