1428943 - Configuring `browser.link.open_newwindow` causes strange behaviour for links in webextension options pages

Status: NEW

(WebExtensions :: General, defect, P5)

Description

[Bruce]

Attachment: Embedded external link.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180104100157

Steps to reproduce:

1. Set `browser.link.open_newwindow` to 1. This should "open links, that would normally open in a new window, in the current tab/window."

2. Install a webextension that meets the following criteria:
(i) `open_in_tab` for `options_ui` is `false` (default)
(ii) there is a link in the add-ons' options_ui page
Sample webextension: Breadcrumbus [1]

3A. Try to middle click the link in the options_ui page.
3B. Try to right click the link, expecting an option to open it in a new tab
3C. Try to right click the link, expecting an option to copy the link so that you can then paste it in a new tab
3C. (Left) click the link

[1] https://addons.mozilla.org/en-US/firefox/addon/breadcrumbus/


Actual results:

3A. Nothing happens
3B. Nothing happens
3C. Nothing happens
3D. Linked page gets embedded into about:addons too. See attached screenshot.


Expected results:

Either let middle clicks work on such links or do not honour the `browser.link.open_newwindow` for such links.

Comment 1

[Rob Wu [:robwu]]

I've tested in Firefox 67.0a1 20190215045130, and can confirm that middle-click (3A) and left click (3D) does not work as expected.

The menu (3B and 3C) does appear though, because menus in options pages are supported as of Firefox 66 - bug 1468460