Closed Bug 1428950 Opened 2 years ago Closed 2 years ago

ipc/chromium/src/base/process_util_bsd.cc:44:57: error: 'const struct base::LaunchOptions' has no member named 'environ'

Categories

(Core :: IPC, defect)

Unspecified
FreeBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

(Keywords: regression, Whiteboard: [npotb])

Attachments

(1 file)

environ was renamed to env_map in mozilla-central changeset 8fdd1dda7efc but process_util_bsd.cc wasn't adjusted.

$ c++ -v
FreeBSD clang version 6.0.0 (trunk 321545) (based on LLVM 6.0.0svn)
Target: x86_64-unknown-freebsd12.0
Thread model: posix
InstalledDir: /usr/bin

$ ./mach build
[...]
ipc/chromium/src/base/process_util_bsd.cc:44:57: error: no member named
      'environ' in 'base::LaunchOptions'
  EnvironmentArray vars = BuildEnvironmentArray(options.environ);
                                                ~~~~~~~ ^
1 error generated.
Whiteboard: [npotb]
OpenBSD failed to build in exactly same way:
http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/2318/steps/build/logs/stdio

Solaris uses process_util_linux.cc, so it isn't affected.
Comment on attachment 8940915 [details]
Bug 1428950 - Unbreak build on BSDs after bug 1297740.

https://reviewboard.mozilla.org/r/211176/#review217024
Attachment #8940915 - Flags: review?(gpascutto) → review+
https://hg.mozilla.org/mozilla-central/rev/4248602674ff
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Assignee: nobody → jbeich
Blocks: 1297740
You need to log in before you can comment on or make changes to this bug.