1428951 - MediaCacheStream::GetDebugInfo() needs to take the cache monitor on the main thread

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://searchfox.org/mozilla-central/rev/cf149b7b63ff97023e28723167725e38cf5df757/dom/media/MediaCache.cpp#250-254

However, MediaCache::Monitor() asserts it is called off the main thread.

I will add another getter to be used by GetDebugInfo() only.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1428951 - add a getter for MediaCacheStream::GetDebugInfo() to take the cache monitor on the main thread.

Review commit: https://reviewboard.mozilla.org/r/211184/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211184/

Comment 2

[Benjamin Chen [:bechen]]

Comment on attachment 8940918 [details]
Bug 1428951 - add a getter for MediaCacheStream::GetDebugInfo() to take the cache monitor on the main thread.

https://reviewboard.mozilla.org/r/211184/#review217036

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8940918 [details]
Bug 1428951 - add a getter for MediaCacheStream::GetDebugInfo() to take the cache monitor on the main thread.

https://reviewboard.mozilla.org/r/211184/#review217300

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1599fb3b3610
add a getter for MediaCacheStream::GetDebugInfo() to take the cache monitor on the main thread. r=bechen,gerald

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/1599fb3b3610