Closed Bug 1428951 Opened 2 years ago Closed 2 years ago

MediaCacheStream::GetDebugInfo() needs to take the cache monitor on the main thread

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/cf149b7b63ff97023e28723167725e38cf5df757/dom/media/MediaCache.cpp#250-254

However, MediaCache::Monitor() asserts it is called off the main thread.

I will add another getter to be used by GetDebugInfo() only.
Assignee: nobody → jwwang
Blocks: 1369263
Priority: -- → P3
Attachment #8940918 - Flags: review?(bechen)
Comment on attachment 8940918 [details]
Bug 1428951 - add a getter for MediaCacheStream::GetDebugInfo() to take the cache monitor on the main thread.

https://reviewboard.mozilla.org/r/211184/#review217036
Attachment #8940918 - Flags: review?(bechen) → review+
Attachment #8940918 - Flags: review?(gsquelart)
Comment on attachment 8940918 [details]
Bug 1428951 - add a getter for MediaCacheStream::GetDebugInfo() to take the cache monitor on the main thread.

https://reviewboard.mozilla.org/r/211184/#review217300
Attachment #8940918 - Flags: review?(gsquelart) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1599fb3b3610
add a getter for MediaCacheStream::GetDebugInfo() to take the cache monitor on the main thread. r=bechen,gerald
https://hg.mozilla.org/mozilla-central/rev/1599fb3b3610
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.