Closed
Bug 1428960
Opened 8 years ago
Closed 8 years ago
-moz-dropdown-list is only allowed to use universal selector
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: tommykuo, Assigned: tommykuo)
References
Details
Attachments
(1 file)
In bug 1425088, I change `*|*::-moz-dropdown-list` to `select::-moz-dropdown-list` and it make Firefox crash.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Attachment #8940929 -
Flags: review?(cam)
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8940929 [details]
Bug 1428960 - Use universal selector for -moz-dropdown-list
https://reviewboard.mozilla.org/r/211198/#review217000
Although there's no risk of web pages encountering this assertion / crash, I think we should still not crash if we parse a UA sheet with an anonymous box selector that uses something other than a universal selector. Can you file a new bug to make us skip over the rule instead of crashing in this case?
Attachment #8940929 -
Flags: review?(cam) → review+
Pushed by tokuo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b9c11ccbd5e
Use universal selector for -moz-dropdown-list r=heycam
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
|
Assignee | |
Updated•8 years ago
|
Blocks: content-select
|
||
Comment 5•8 years ago
|
||
(In reply to Cameron McCormack (:heycam) from comment #2)
> Comment on attachment 8940929 [details]
> Bug 1428960 - Use universal selector for -moz-dropdown-list
>
> https://reviewboard.mozilla.org/r/211198/#review217000
>
> Although there's no risk of web pages encountering this assertion / crash, I
> think we should still not crash if we parse a UA sheet with an anonymous box
> selector that uses something other than a universal selector. Can you file
> a new bug to make us skip over the rule instead of crashing in this case?
I believe the crash was added intentionally to warn developer not to do so, since stylo doesn't handle that case.
You need to log in
before you can comment on or make changes to this bug.
Description
•