Closed Bug 1428960 Opened 2 years ago Closed 2 years ago

-moz-dropdown-list is only allowed to use universal selector

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: kuoe0.tw, Assigned: kuoe0.tw)

References

Details

Attachments

(1 file)

In bug 1425088, I change `*|*::-moz-dropdown-list` to `select::-moz-dropdown-list` and it make Firefox crash.
Attachment #8940929 - Flags: review?(cam)
Comment on attachment 8940929 [details]
Bug 1428960 - Use universal selector for -moz-dropdown-list

https://reviewboard.mozilla.org/r/211198/#review217000

Although there's no risk of web pages encountering this assertion / crash, I think we should still not crash if we parse a UA sheet with an anonymous box selector that uses something other than a universal selector.  Can you file a new bug to make us skip over the rule instead of crashing in this case?
Attachment #8940929 - Flags: review?(cam) → review+
Pushed by tokuo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b9c11ccbd5e
Use universal selector for -moz-dropdown-list r=heycam
https://hg.mozilla.org/mozilla-central/rev/1b9c11ccbd5e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
(In reply to Cameron McCormack (:heycam) from comment #2)
> Comment on attachment 8940929 [details]
> Bug 1428960 - Use universal selector for -moz-dropdown-list
> 
> https://reviewboard.mozilla.org/r/211198/#review217000
> 
> Although there's no risk of web pages encountering this assertion / crash, I
> think we should still not crash if we parse a UA sheet with an anonymous box
> selector that uses something other than a universal selector.  Can you file
> a new bug to make us skip over the rule instead of crashing in this case?

I believe the crash was added intentionally to warn developer not to do so, since stylo doesn't handle that case.
You need to log in before you can comment on or make changes to this bug.