1429006 - [Regression] Find From Menu is failing on iPad, next/previous buttons do not work

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Isabel Rios[:isabel_rios]]

Attachment: Next_Previous Buttons.png

Seen on latest master: 903fbda9cc56e7f3c4d652c4bb76de6dd401e34f

Find From Menu test is not working on iPad. XCUITest failed because it is not possible to tap on Next button once you search for a word.
It is reproducible manually too on iPad sim.

Step:
- Go to https://www.mozilla.org/en-US/book/
- Tap on Page Options menu and select: Find in Page
- On the search bar type: Book
- Tap on the next (arrow down) button (see picture)

Actual
Nothing happens when tapping on it

Expected
The second Book word found should be selected and the counter increased from 1/6 to 2/6.

This seems to be introduced by the latest commit.
Failing on: https://github.com/mozilla-mobile/firefox-ios/commit/903fbda9cc56e7f3c4d652c4bb76de6dd401e34f

Latest working on previous commit: https://github.com/mozilla-mobile/firefox-ios/commit/0376ed2388463a7bc2fdff1d907b91da4cb13135

Comment 1

[Isabel Rios[:isabel_rios]]

Please see bug 1420887, looks like due to its fixed this regression appeared

Comment 2

[Isabel Rios[:isabel_rios]]

More info here: tested on a real iPad device with latest nightly (8564) this issue is reproducible. 

And the close button on that search bar does not work either, it is not only the next/previous buttons that do not respond, looks like it is the whole search bar.

Comment 3

[Catalin Suciu [:csuciu]]

Hey Garvan, do you have time to take a look at this? 
This is a recent regression that breaks the entire "find in page" bar on iPad's. We should have this fixed before the first Beta 11.0 gets released.

Comment 4

[:garvan]

I'll take a look

Comment 5

[:garvan]

Attachment: Pull request

Comment 6

[:garvan]

Comment on attachment 8942672 [details] [review]
Pull request

The stackview is supposed to have a max width, fixing patch.

Comment 7

[:garvan]

Attachment: Pull request

Comment 8

[:garvan]

landed on master

Comment 9

[:garvan]

Follow up for Snackbar animation improvement: https://bugzilla.mozilla.org/show_bug.cgi?id=1431834