Created attachment 8940992 [details] Next_Previous Buttons.png Seen on latest master: 903fbda9cc56e7f3c4d652c4bb76de6dd401e34f Find From Menu test is not working on iPad. XCUITest failed because it is not possible to tap on Next button once you search for a word. It is reproducible manually too on iPad sim. Step: - Go to https://www.mozilla.org/en-US/book/ - Tap on Page Options menu and select: Find in Page - On the search bar type: Book - Tap on the next (arrow down) button (see picture) Actual Nothing happens when tapping on it Expected The second Book word found should be selected and the counter increased from 1/6 to 2/6. This seems to be introduced by the latest commit. Failing on: https://github.com/mozilla-mobile/firefox-ios/commit/903fbda9cc56e7f3c4d652c4bb76de6dd401e34f Latest working on previous commit: https://github.com/mozilla-mobile/firefox-ios/commit/0376ed2388463a7bc2fdff1d907b91da4cb13135
Summary: [Regression] Find From Menu is failing in iPad → [Regression] Find From Menu is failing on iPad, next/previous buttons do not work
Please see bug 1420887, looks like due to its fixed this regression appeared
More info here: tested on a real iPad device with latest nightly (8564) this issue is reproducible. And the close button on that search bar does not work either, it is not only the next/previous buttons that do not respond, looks like it is the whole search bar.
Hey Garvan, do you have time to take a look at this? This is a recent regression that breaks the entire "find in page" bar on iPad's. We should have this fixed before the first Beta 11.0 gets released.
I'll take a look
Assignee: nobody → gkeeley
Created attachment 8942672 [details] [review] Pull request
Comment on attachment 8942672 [details] [review] Pull request The stackview is supposed to have a max width, fixing patch.
Created attachment 8942685 [details] [review] Pull request
landed on master
Status: NEW → RESOLVED
Last Resolved: 3 days ago
Resolution: --- → FIXED
Follow up for Snackbar animation improvement: https://bugzilla.mozilla.org/show_bug.cgi?id=1431834
You need to log in before you can comment on or make changes to this bug.